Retry code coverage upload 3 times and don't fail build

.circleci/config.yml

@@ -42,7 +42,7 @@ _refs:
     name: Upload coverage to codecov.io
     command: |
       ./node_modules/nyc/bin/nyc.js report --reporter=lcov
-      curl -s https://codecov.io/bash | bash -s -- -f ./test-results/coverage/lcov.info
+      node ./scripts/uploadCodeCoverage.js
   gus-prepare-environment-variables: &gus-prepare-environment-variables
     name: 'Prepare environment variables for GUS Change Case Management'
     command: |

package.json

@@ -69,7 +69,7 @@
     "local:install": "./scripts/localInstall.js install",
     "local:link": "./scripts/localInstall.js link",
     "local:unlink": "./scripts/localInstall.js unlink",
-    "test": "shx rm -rf ./test-results && nyc mocha && node ./scripts/verifyTestArtifacts",
+    "test": "shx rm -rf ./test-results && nyc mocha",
     "update:registry": "node ./scripts/metadata-registry/update.js"
   },
   "husky": {

scripts/uploadCodeCoverage.js

@@ -0,0 +1,32 @@
+#!/usr/bin/env node
+
+const { execSilent } = require('./util');
+
+/**
+ * Script for publishing code coverage results to Codecov.io. Intended to run
+ * during a CircleCI job.
+ *
+ * Not using path.join for the path to coverage report because in the Windows job,
+ * this script runs with bash.exe to allow running the codecov.io publish script.
+ * Hence using a Windows formatted path will confuse the process.
+ */
+
+const MAX_ATTEMPTS = 3;
+
+let attempts = 0;
+
+do {
+  try {
+    const result = execSilent('curl -s https://codecov.io/bash | bash -s -- -f test-results/coverage/lcov.info');
+    console.log(result.stdout);
+    break;
+  } catch (e) {
+    attempts += 1;
+    let message = `Failed to publish coverage results on attempt ${attempts}`;
+    if (attempts < MAX_ATTEMPTS) {
+      message += ' - trying again...';
+    }
+    console.log(message);
+    console.log(e.message);
+  }
+} while (attempts < MAX_ATTEMPTS);