fix: handle and throw a better error for getCurrentApiVersion

Author: shetzel

src/registry/coverage.ts

@@ -9,6 +9,8 @@
 import { OptionsOfTextResponseBody } from 'got';
 import got from 'got';
 import { ProxyAgent } from 'proxy-agent';
+import { isString } from '@salesforce/ts-types';
+import { SfError } from '@salesforce/core';
 import { CoverageObject } from '../../src/registry/types';
 
 const getProxiedOptions = (url: string): OptionsOfTextResponseBody => ({
@@ -31,9 +33,16 @@ let apiVer: number;
 
 export const getCurrentApiVersion = async (): Promise<number> => {
   if (apiVer === undefined) {
-    const apiVersionsUrl = 'https://appexchange.salesforce.com/services/data';
-    const lastVersionEntry = (await got(getProxiedOptions(apiVersionsUrl)).json<ApiVersion[]>()).pop() as ApiVersion;
-    apiVer = +lastVersionEntry.version;
+    try {
+      const apiVersionsUrl = 'https://appexchange.salesforce.com/services/data';
+      const lastVersionEntry = (await got(getProxiedOptions(apiVersionsUrl)).json<ApiVersion[]>()).at(-1) as ApiVersion;
+      apiVer = +lastVersionEntry.version;
+    } catch (e: unknown) {
+      const err = e instanceof Error ? e : SfError.wrap(isString(e) ? e : 'unknown');
+      const eMsg = 'Unable to get a current API version from the appexchange org';
+      const eActions = ['Provide an API version explicitly', 'Set an API version in the project configuration'];
+      throw new SfError(eMsg, 'ApiVersionRetrievalError', eActions, err);
+    }
   }
   return apiVer;
 };