-
Notifications
You must be signed in to change notification settings - Fork 74
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: forcedotcom/sfdx-core
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 8.23.2
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: forcedotcom/sfdx-core
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 8.23.3
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 11 commits
- 7 files changed
- 4 contributors
Commits on Oct 14, 2025
-
fix: handle options object in readFile/readFileSync for isomorphic-gi…
…t compatibility The current implementation only accepts encoding as a positional parameter, but Node.js fs.readFile/readFileSync accept either a string encoding OR an options object with { encoding: 'utf8' }. Libraries like isomorphic-git call fs.readFile with an options object: fs.readFile(path, { encoding: 'utf8' }) This was causing the encoding to be passed incorrectly to memfs, resulting in Buffers being returned even when 'utf8' encoding was requested, leading to 'X is not a function' errors when string methods were called on Buffers. Changes: - Updated readFile signature to accept BufferEncoding | { encoding?: BufferEncoding } - Updated readFileSync signature to accept BufferEncoding | { encoding?: BufferEncoding } - Extract encoding from options object if needed before passing to memfs - Ensures compatibility with both calling conventions This fixes issues when using isomorphic-git with memfs in browser environments.3Configuration menu - View commit details
-
Copy full SHA for 6239350 - Browse repository at this point
Copy the full SHA 6239350View commit details -
Configuration menu - View commit details
-
Copy full SHA for fc8a88d - Browse repository at this point
Copy the full SHA fc8a88dView commit details -
3
Configuration menu - View commit details
-
Copy full SHA for 73a912a - Browse repository at this point
Copy the full SHA 73a912aView commit details
Commits on Oct 15, 2025
-
3
Configuration menu - View commit details
-
Copy full SHA for 6636048 - Browse repository at this point
Copy the full SHA 6636048View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9920c39 - Browse repository at this point
Copy the full SHA 9920c39View commit details -
4
Configuration menu - View commit details
-
Copy full SHA for cf6aaf3 - Browse repository at this point
Copy the full SHA cf6aaf3View commit details -
3
Configuration menu - View commit details
-
Copy full SHA for 6ad56a9 - Browse repository at this point
Copy the full SHA 6ad56a9View commit details
Commits on Oct 20, 2025
-
3
Configuration menu - View commit details
-
Copy full SHA for f06ad4d - Browse repository at this point
Copy the full SHA f06ad4dView commit details
Commits on Oct 21, 2025
-
4
Configuration menu - View commit details
-
Copy full SHA for 0e985d5 - Browse repository at this point
Copy the full SHA 0e985d5View commit details -
Merge pull request #1244 from forcedotcom/fix/memfs-readfile-encoding…
…-option fix: handle options object in readFile/readFileSync for isomorphic-git compatibility W-19263112
Configuration menu - View commit details
-
Copy full SHA for bf448b5 - Browse repository at this point
Copy the full SHA bf448b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 64acea4 - Browse repository at this point
Copy the full SHA 64acea4View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 8.23.2...8.23.3