Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: forcedotcom/sfdx-core
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 8.23.2
Choose a base ref
...
head repository: forcedotcom/sfdx-core
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 8.23.3
Choose a head ref
  • 11 commits
  • 7 files changed
  • 4 contributors

Commits on Oct 14, 2025

  1. fix: handle options object in readFile/readFileSync for isomorphic-gi…

    …t compatibility
    
    The current implementation only accepts encoding as a positional parameter,
    but Node.js fs.readFile/readFileSync accept either a string encoding OR an
    options object with { encoding: 'utf8' }.
    
    Libraries like isomorphic-git call fs.readFile with an options object:
      fs.readFile(path, { encoding: 'utf8' })
    
    This was causing the encoding to be passed incorrectly to memfs, resulting
    in Buffers being returned even when 'utf8' encoding was requested, leading
    to 'X is not a function' errors when string methods were called on Buffers.
    
    Changes:
    - Updated readFile signature to accept BufferEncoding | { encoding?: BufferEncoding }
    - Updated readFileSync signature to accept BufferEncoding | { encoding?: BufferEncoding }
    - Extract encoding from options object if needed before passing to memfs
    - Ensures compatibility with both calling conventions
    
    This fixes issues when using isomorphic-git with memfs in browser environments.
    actions-user committed Oct 14, 2025
    3 Configuration menu
    Copy the full SHA
    6239350 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fc8a88d View commit details
    Browse the repository at this point in the history
  3. refactor: tighter ts types

    mshanemc committed Oct 14, 2025
    3 Configuration menu
    Copy the full SHA
    73a912a View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2025

  1. 3 Configuration menu
    Copy the full SHA
    6636048 View commit details
    Browse the repository at this point in the history
  2. fix: bump versions

    shetzel committed Oct 15, 2025
    Configuration menu
    Copy the full SHA
    9920c39 View commit details
    Browse the repository at this point in the history
  3. fix: bump salesforce/schemas

    shetzel committed Oct 15, 2025
    4 Configuration menu
    Copy the full SHA
    cf6aaf3 View commit details
    Browse the repository at this point in the history
  4. fix: bump ts-types

    shetzel committed Oct 15, 2025
    3 Configuration menu
    Copy the full SHA
    6ad56a9 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2025

  1. chore: bump a lib

    shetzel committed Oct 20, 2025
    3 Configuration menu
    Copy the full SHA
    f06ad4d View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2025

  1. chore: bump semver

    shetzel committed Oct 21, 2025
    4 Configuration menu
    Copy the full SHA
    0e985d5 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1244 from forcedotcom/fix/memfs-readfile-encoding…

    …-option
    
    fix: handle options object in readFile/readFileSync for isomorphic-git compatibility W-19263112
    shetzel authored Oct 21, 2025
    Configuration menu
    Copy the full SHA
    bf448b5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    64acea4 View commit details
    Browse the repository at this point in the history
Loading