update

Author: ppandit-sfdc

src/datacustomcode/run.py

@@ -76,16 +76,10 @@ def run_entrypoint(
             f"Please ensure config.json contains a 'dataspace' field."
         )
 
-    # Load config file first (if provided) so that dataspace from config.json
-    # can override any dataspace in the config file
+    # Load config file (if provided)
     if config_file:
         config.load(config_file)
 
-    # Add dataspace to reader and writer config options
-    # (after loading config file to ensure it takes precedence)
-    _set_config_option(config.reader_config, "dataspace", dataspace)
-    _set_config_option(config.writer_config, "dataspace", dataspace)
-
     if profile != "default":
         _set_config_option(config.reader_config, "credentials_profile", profile)
         _set_config_option(config.writer_config, "credentials_profile", profile)

tests/test_run.py

@@ -241,25 +241,13 @@ class TestDataspaceScenarios:
     """Test dataspace functionality in run_entrypoint."""
 
     def test_run_entrypoint_with_default_dataspace(self):
-        """Test that run_entrypoint sets dataspace='default' correctly."""
+        """Test that run_entrypoint runs successfully with dataspace='default'."""
         with tempfile.NamedTemporaryFile(suffix=".py", delete=False) as temp:
             entrypoint_content = textwrap.dedent(
                 """
-                # Test entrypoint
-                from datacustomcode.config import config
+                # Test entrypoint - just verify it runs
                 with open("dataspace_output.txt", "w") as f:
-                    rds = (
-                        config.reader_config.options.get("dataspace")
-                        if config.reader_config
-                        else None
-                    )
-                    wds = (
-                        config.writer_config.options.get("dataspace")
-                        if config.writer_config
-                        else None
-                    )
-                    f.write(f"Reader dataspace: {rds}\\n")
-                    f.write(f"Writer dataspace: {wds}\\n")
+                    f.write("Entrypoint executed successfully\\n")
             """
             )
             temp.write(entrypoint_content.encode("utf-8"))
@@ -278,11 +266,10 @@ def test_run_entrypoint_with_default_dataspace(self):
                 profile="default",
             )
 
-            # Verify dataspace was set
+            # Verify entrypoint executed
             with open("dataspace_output.txt", "r") as f:
                 content = f.read()
-                assert "Reader dataspace: default" in content
-                assert "Writer dataspace: default" in content
+                assert "Entrypoint executed successfully" in content
 
         finally:
             if os.path.exists(entrypoint_file):
@@ -293,26 +280,14 @@ def test_run_entrypoint_with_default_dataspace(self):
                 os.unlink("dataspace_output.txt")
 
     def test_run_entrypoint_with_custom_dataspace(self):
-        """Test that run_entrypoint sets custom dataspace correctly."""
+        """Test that run_entrypoint runs successfully with custom dataspace."""
         custom_dataspace = "dataspace-1"
         with tempfile.NamedTemporaryFile(suffix=".py", delete=False) as temp:
             entrypoint_content = textwrap.dedent(
                 """
-                # Test entrypoint
-                from datacustomcode.config import config
+                # Test entrypoint - just verify it runs
                 with open("dataspace_output.txt", "w") as f:
-                    rds = (
-                        config.reader_config.options.get("dataspace")
-                        if config.reader_config
-                        else None
-                    )
-                    wds = (
-                        config.writer_config.options.get("dataspace")
-                        if config.writer_config
-                        else None
-                    )
-                    f.write(f"Reader dataspace: {rds}\\n")
-                    f.write(f"Writer dataspace: {wds}\\n")
+                    f.write("Entrypoint executed successfully\\n")
             """
             )
             temp.write(entrypoint_content.encode("utf-8"))
@@ -324,18 +299,19 @@ def test_run_entrypoint_with_custom_dataspace(self):
             json.dump({"dataspace": custom_dataspace}, f)
 
         try:
+            # Verify entrypoint runs successfully with custom dataspace
+            # (if dataspace validation failed, this would raise an error)
             run_entrypoint(
                 entrypoint=entrypoint_file,
                 config_file=None,
                 dependencies=[],
                 profile="default",
             )
 
-            # Verify custom dataspace was set
+            # Verify entrypoint executed
             with open("dataspace_output.txt", "r") as f:
                 content = f.read()
-                assert f"Reader dataspace: {custom_dataspace}" in content
-                assert f"Writer dataspace: {custom_dataspace}" in content
+                assert "Entrypoint executed successfully" in content
 
         finally:
             if os.path.exists(entrypoint_file):