Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to convert local tests to Web Platform Tests? #3

Closed
guest271314 opened this issue Feb 19, 2018 · 7 comments
Closed

How to convert local tests to Web Platform Tests? #3

guest271314 opened this issue Feb 19, 2018 · 7 comments

Comments

@guest271314
Copy link

Have composed several tests relevant to Web Speech API web-platform-tests/wpt#8795 and SSML parsing web-platform-tests/wpt#8712, https://github.com/guest271314/SpeechSynthesisSSMLParser.

What is the canonical approach to incorporate these tests into the respective Web Platform Tests folder, or create the folder (SSML)?

Would the tests (manual) be useful for the Web Platform Tests repository?

(Asked same question at http://irc.w3.org/ #testing though did not get a response before submitting this issue.)

@foolip
Copy link
Owner

foolip commented Feb 20, 2018

Manual tests are fine if nothing else is possible, just name them foo-manual.html. https://github.com/w3c/web-platform-tests/tree/master/speech-api is the directory for Web Speech API.

As for SSML, it looks like Chromium doesn't support that, does any implementation?

@guest271314
Copy link
Author

Browsers do not come shipped with an SSML parser that am aware of. Tried to find such existing code https://softwareengineering.stackexchange.com/questions/362911/how-to-extract-ssml-parsing-code-of-espeak-to-implement-ssml-parsing-at-speechsy before began composing the parser in JavaScript; see also https://stackoverflow.com/a/48504311/.

The code at https://github.com/guest271314/SpeechSynthesisSSMLParser implements an SSML parser (to the point have reached as to the standardized elements and attributes) following the specification using JavaScript.

The concern that have is the use of arrow functions, const, etc. within the current code. If that is not an issue will create the "ssml" folder at Web Platform Tests and include the tests that have completed so far.

@foolip
Copy link
Owner

foolip commented Feb 20, 2018

I was about to file an issue about SSML not being implemented, but used WICG/speech-api#10 instead.

Since the spec doesn't actually say how it should work I don't know how to write tests for it, and more importantly, if nobody is inclined to implement it then the tests will just be failing forever.

@guest271314
Copy link
Author

Since the spec doesn't actually say how it should work

Not sure what you mean?

@foolip
Copy link
Owner

foolip commented Feb 20, 2018

The spec doesn't spell out what test should be performed on the input to determine whether it is SSML or should be treated as plain text.

@guest271314
Copy link
Author

Yes, that is unclear.

@guest271314
Copy link
Author

The spec doesn't spell out what test should be performed on the input to determine whether it is SSML or should be treated as plain text.

When re-reading the specification the requirement is spelled out

5.2.3 SpeechSynthesisUtterance Attributes

or a complete, well-formed SSML document.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants