Replies: 7 comments 1 reply
-
The same is true for PR's. |
Beta Was this translation helpful? Give feedback.
-
As an example: a very old #27 is also referenced in a |
Beta Was this translation helpful? Give feedback.
-
I fully agree that issues/PRs need a cleanup! 👍 Deciding what to close as 'Won't fix' means a lot of work however and I think it's not something one person should do alone. Maybe we should start collaboratively setting up a list of issues/PRs, that are likely to be obsolete, here in this discussion. That way everyone gets a chance to raise objections. We could leave it here for 1-2 months and then close everything that's not been appealed...? |
Beta Was this translation helpful? Give feedback.
-
I have added the label To some degree cleaning PR's seems even more useful: either it is something which can still be added or it is no longer needed, wanted or adding value. |
Beta Was this translation helpful? Give feedback.
-
Went through the majority of PR's not from any of you and added my comment and |
Beta Was this translation helpful? Give feedback.
-
I think, what might help preventing stale issues/PRs in the future (at least a little) is providing templates for them - e.g. https://axolo.co/blog/p/part-3-github-pull-request-template I guess something as simple as this must have been discussed in the past...? If so, why has it been dismissed? Also - as a general rule - I would vote to always try and create an issue before creating a PR. (Otherwise the description of what is to be implemented/fixed tends to be mixed with how it is being implemented/fixed. When reading such an issue-less PR after some time has passed, it's hard to figure out, what the original problem was.) |
Beta Was this translation helpful? Give feedback.
-
For reference the what to do with stale PR's comment as a discussion item on the cleanup. |
Beta Was this translation helpful? Give feedback.
-
As we are looking into what would fit on the roadmap: another good moment to go over what is in the issue list and close what is no longer of any importance.
I have not enough background information, at this time, but issues from more then 5-12(!) years ago have likely not any value anymore.
I would suggest to go through what anybody feels may still be relevant and add a comment to that effect. The label
technical debt
is also useful for issues which still need addressing.The others could get a
won't fix
label and be closed.This would be helpful to get to a list of items which actually need addressing.
Thoughts?
Beta Was this translation helpful? Give feedback.
All reactions