Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test the /sample/test1.jl interactive notebook with Puppeteer #867

Open
pankgeorg opened this issue Jan 21, 2021 · 0 comments
Open

Test the /sample/test1.jl interactive notebook with Puppeteer #867

pankgeorg opened this issue Jan 21, 2021 · 0 comments
Labels
frontend Concerning the HTML editor good first issue Good for newcomers tests issues that improve the code coverage and the automatic testing

Comments

@pankgeorg
Copy link
Collaborator

pankgeorg commented Jan 21, 2021

Introduction

This is a newcomer-friendly issue.
Most of Pluto's functionality is documented in this notebook that exists as part of the codebase. We use it whenever we change something to our frontend code, to check that things are still working.

Right now we run this notebook manually, and perform the checks by hand. This issue is about running and testing the reactivity and the features of pluto automatically with the Puppeteer framework.

Puppeteer is a Chromium browser with an API, that we already use to run some simple tests.

What needs to be done

  1. create a new branch
  2. create a new .js file in /test/frontend/__tests__
  3. add code that will perform actions that a user would do. In puppeteer we usually do that waiting for selectors to show up in the DOM and then executing some browser code.
  4. make sure that the action had the correct result and nothing exploded

You can take a look at the existing tests, though this one is more advanced. Eventually, we would like all tests from this notebook to run automatically, but small steps are also welcome!

If you're interested in doing that and have more questions, feel free to ask here or in zulip

@pankgeorg pankgeorg added good first issue Good for newcomers frontend Concerning the HTML editor tests issues that improve the code coverage and the automatic testing labels Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Concerning the HTML editor good first issue Good for newcomers tests issues that improve the code coverage and the automatic testing
Projects
None yet
Development

No branches or pull requests

1 participant