Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting the log filtering granularity. #3073

Open
KristofferC opened this issue Oct 23, 2024 · 2 comments
Open

Allow setting the log filtering granularity. #3073

KristofferC opened this issue Oct 23, 2024 · 2 comments
Labels
frontend Concerning the HTML editor good first issue Good for newcomers logging About `@info`, `@warn`, etc

Comments

@KristofferC
Copy link

Right now, Pluto filters out log messages which may or may not be desired. The way it does this is by two hardcoded constants at

const LOGS_VISIBLE_START = 60
const LOGS_VISIBLE_END = 20

It would be good if the logging filtering could either be customized or turned off because sometimes you actually want to read the log messages you output.

@fonsp fonsp added good first issue Good for newcomers frontend Concerning the HTML editor labels Oct 25, 2024
@fonsp
Copy link
Owner

fonsp commented Oct 25, 2024

Thanks for the issue!

I think we can add a more... button to show all logs, just like we do for long arrays:

image

@fonsp
Copy link
Owner

fonsp commented Oct 25, 2024

I labeled this as a "Good First Issue"! If you learn the basics about React Hooks, this should be easy to implement!

Also take a look at how we implemented show types... in the stack trace:

image
map(sqrt, (-1,[],[],[],[],[],[]))

@fonsp fonsp added the logging About `@info`, `@warn`, etc label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Concerning the HTML editor good first issue Good for newcomers logging About `@info`, `@warn`, etc
Projects
None yet
Development

No branches or pull requests

2 participants