-
-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No dependency resolution for can_macroexpand
+ external macro
#2811
Comments
Thanks for writing a MWE! |
I was facing the same issue and I think go introduced in a recent version. In my git history I can see that my notebook file got "corrupted" without having docstrings added. |
It is interesting because it should carry on with the macro resolution but it doesn't. Maybe we can revert for now? I think the problem is that we don't mark failed ExEx.try_macroexpand as unresolved so they are never resolved. See #1388 (comment). Another example with Screencast.from.01-03-2024.14.04.50.webm |
can_macroexpand
+ external macro
Fix issue from Pluto, see fonsp/Pluto.jl#2811 and fonsp/Pluto.jl#2838
A function definition that use the
@htl
macro and has a docstrings attached to it cannot be called before the definition as the cell isn't ordered properly.You can see in MWE that the cell with the call to the bad function is located
before the function definition and does not work. When placed after, it does.
Note that this only seems to be when combining
@htl
and docstring.Minimum Working Example
Tested in Pluto v0.19.38
The text was updated successfully, but these errors were encountered: