Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSockets can break after computer in hibernation #28

Closed
fonsp opened this issue Mar 19, 2020 · 3 comments
Closed

WebSockets can break after computer in hibernation #28

fonsp opened this issue Mar 19, 2020 · 3 comments
Assignees
Labels
backend Concerning the julia server and runtime bug Something isn't working

Comments

@fonsp
Copy link
Owner

fonsp commented Mar 19, 2020

I've seen this a few times - when I leave Pluto running overnight, and put my computer in hibernate (i think?), the WebSocket communication is broken.

On the client side:
HTTP requests work fine. Opening a new notebook (with new UUID) still works.
The socket is openened, but no messages are received. I can send (bad) messages without closing the socket.

On the server side:
There are no errors in Pluto, not even for bad messages or closing the socket. Last night's sockets closed, and this error was thrown in Pluto.jl:457.

system: Windows 10, pluto running on Julia v1.0 in Legacy WSL Ubuntu 18

@fonsp fonsp added bug Something isn't working backend Concerning the julia server and runtime labels Mar 19, 2020
@fonsp fonsp self-assigned this Mar 19, 2020
@fonsp fonsp added the one day Closed because we won't work on it soon, will be opened again later. label Apr 7, 2020
@fonsp fonsp closed this as completed Apr 7, 2020
@fonsp
Copy link
Owner Author

fonsp commented Apr 10, 2020

This is the intended behaviour: if the client wasn't alive to process updates, the connection should be closed. (Otherwise the notebook can get out of sync while it is sleeping 😴)

@fonsp fonsp removed the one day Closed because we won't work on it soon, will be opened again later. label Apr 10, 2020
@fonsp
Copy link
Owner Author

fonsp commented Apr 27, 2020

Yes @fonsp but what about unsaved local changes? It needs the websocket connection to save those to a file.

It should attempt to reconnect and reload all cells when this happens, but all unsaved changes should remain.

@fonsp fonsp added the one day Closed because we won't work on it soon, will be opened again later. label Apr 27, 2020
@fonsp
Copy link
Owner Author

fonsp commented Jul 22, 2020

#188

@fonsp fonsp removed the one day Closed because we won't work on it soon, will be opened again later. label Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Concerning the julia server and runtime bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant