Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging: use the JULIA_DEBUG ENV value #2509

Open
fonsp opened this issue Mar 14, 2023 · 1 comment
Open

Logging: use the JULIA_DEBUG ENV value #2509

fonsp opened this issue Mar 14, 2023 · 1 comment
Labels
help welcome If you are experienced in this topic - let us know! logging About `@info`, `@warn`, etc

Comments

@fonsp
Copy link
Owner

fonsp commented Mar 14, 2023

With the default logger (in the REPL), you can use the JULIA_DEBUG ENV variable to control the display of @debug logs: https://docs.julialang.org/en/v1/stdlib/Logging/#Environment-variables We should also support this feature in our custom PlutoLogger.

The default implementation is here: https://github.com/JuliaLang/julia/blob/6c2410361a6e413652ed89fb206d4dc6c2af89c9/base/logging.jl#L542 This looks pretty complicated, but maybe there is a way to call this mechanism directly from our code. It might be worth investigating how https://github.com/JuliaLogging/TerminalLoggers.jl did it.
@fonsp fonsp added help welcome If you are experienced in this topic - let us know! logging About `@info`, `@warn`, etc labels Mar 14, 2023
@fonsp fonsp mentioned this issue Mar 14, 2023
Open
@fonsp
Copy link
Owner Author

fonsp commented Mar 14, 2023

This would also fix #2487

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help welcome If you are experienced in this topic - let us know! logging About `@info`, `@warn`, etc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fonsp