Fix Android not being detected with latest NDK toolchain #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the NDK 13b toolchain standalone or with CMake, ANDROID is not defined, but __ANDROID__ is defined instead.
|
Thanks, merged. |
foonathan
pushed a commit
that referenced
this pull request
Jun 8, 2017
When using the NDK 13b toolchain standalone or with CMake, ANDROID is not defined, but __ANDROID__ is defined instead. (cherry picked from commit bc6af75)
|
Android maintainer here: yes, |
vitaut
added a commit
that referenced
this pull request
Feb 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the NDK 13b toolchain standalone or with CMake, ANDROID is not defined,
but ANDROID is defined instead.
I can't say for sure that is and will always be the case, but it works for me, and I have some unofficial sources: http://stackoverflow.com/a/15335544 and http://markmail.org/message/5ekhfztchs45lz3n#query:+page:1+mid:jfqgzrmwm37uyrt6+state:results