Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add args() accessor back to fmt::format_context #4310

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Add args() accessor back to fmt::format_context #4310

merged 2 commits into from
Jan 17, 2025

Conversation

Erroneous1
Copy link
Contributor

Fix #4307

  • Add args() const accessor back to fmt::format_context
  • Add test that would fail to compile if you can't create a fmt::format_context from another fmt::format_context using args() const and locale() const

@Erroneous1
Add args() accessor back to fmt::format_context
30f8834 
Add test that would fail to compile if you can't create a fmt::format_context from another fmt::format_context
vitaut
vitaut requested changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@vitaut vitaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

test/compile-error-test/CMakeLists.txt Outdated Show resolved Hide resolved
@Erroneous1
Copy link
Contributor Author

@vitaut Thank you for the great library

@vitaut vitaut merged commit 937b7c5 into fmtlib:master Jan 17, 2025
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitaut vitaut vitaut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't access context args() directly in 11.1.0
2 participants
@Erroneous1 @vitaut