Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed #190 Argument shadowing and Clang pedantic support #191

Merged
merged 1 commit into from
Aug 4, 2015

Conversation

rpopescu
Copy link
Contributor

@rpopescu rpopescu commented Aug 4, 2015

No description provided.

@rpopescu
Copy link
Contributor Author

rpopescu commented Aug 4, 2015

That's actually the first thing I tried, and it doesn't work - the warning flags are not being set.
I have no idea why that is.
Cmake since 3.0.2 at least says that COMPILE_FLAGS is deprecated, so I don't think that the current way it's being done is the best one.

vitaut added a commit that referenced this pull request Aug 4, 2015
fixed #190 Argument shadowing and Clang pedantic support
@vitaut vitaut merged commit f9813c3 into fmtlib:master Aug 4, 2015
@vitaut
Copy link
Contributor

vitaut commented Aug 4, 2015

It turned out the compile flags where overwritten later. This is fixed in a8d12ad. COMPILE_FLAGS are used for compatibility with older CMake such as the one installed on Travis CI. At some point these will be replaced with target_compile_options.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants