Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calling convert should be done using the fully qualified name of the convert function #425

Closed
gabime opened this issue Nov 19, 2016 · 1 comment
Closed

Calling convert should be done using the fully qualified name of the convert function #425

gabime opened this issue Nov 19, 2016 · 1 comment

Comments

@gabime
Copy link
Contributor

gabime commented Nov 19, 2016

As discussed in this stackoverflow question about spdlog, seems that the call to convert in line 1276 in format.h should be done using fully qulified name of convert, or the compiler produces an error (due to conflicting 'convert' function from another library).
vitaut added a commit that referenced this issue Nov 19, 2016
@vitaut
Fix collision with global convert function (#425)
796beaa
@vitaut
Copy link
Contributor

vitaut commented Nov 19, 2016

Fixed in 796beaa. Thanks for reporting!

@vitaut vitaut closed this as completed Nov 19, 2016
foonathan pushed a commit that referenced this issue Jun 8, 2017
@vitaut @foonathan
Fix collision with global convert function (#425)
a55df13 
(cherry picked from commit 796beaa)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vitaut @gabime