%.f should have zero precision, not default precision

fmtlib · Apr 8, 2017 · cbac016 · cbac016
1 parent c03f55e
commit cbac016
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/fmt/printf.h b/fmt/printf.h
@@ -439,6 +439,8 @@ void PrintfFormatter<Char, AF>::format(BasicCStringRef<Char> format_str) {
       } else if (*s == '*') {
         ++s;
         spec.precision_ = internal::PrecisionHandler().visit(get_arg(s));
+      } else {
+        spec.precision_ = 0;
       }
     }
 

diff --git a/test/printf-test.cc b/test/printf-test.cc
@@ -401,6 +401,9 @@ TEST(PrintfTest, LongLong) {
 
 TEST(PrintfTest, Float) {
   EXPECT_PRINTF("392.650000", "%f", 392.65);
+  EXPECT_PRINTF("392.65", "%.2f", 392.65);
+  EXPECT_PRINTF("392.6", "%.1f", 392.65);
+  EXPECT_PRINTF("393", "%.f", 392.65);
   EXPECT_PRINTF("392.650000", "%F", 392.65);
   EXPECT_PRINTF("392.65", "%s", 392.65);
   char buffer[BUFFER_SIZE];