%.f should have zero precision, not default precision

manylegged · vitaut · commit cbac016cced4 · 2017-04-08T07:18:10.000-07:00
diff --git a/fmt/printf.h b/fmt/printf.h
@@ -439,6 +439,8 @@ void PrintfFormatter<Char, AF>::format(BasicCStringRef<Char> format_str) {
       } else if (*s == '*') {
         ++s;
         spec.precision_ = internal::PrecisionHandler().visit(get_arg(s));
+      } else {
+        spec.precision_ = 0;
       }
     }
 
diff --git a/test/printf-test.cc b/test/printf-test.cc
@@ -401,6 +401,9 @@ TEST(PrintfTest, LongLong) {
 
 TEST(PrintfTest, Float) {
   EXPECT_PRINTF("392.650000", "%f", 392.65);
+  EXPECT_PRINTF("392.65", "%.2f", 392.65);
+  EXPECT_PRINTF("392.6", "%.1f", 392.65);
+  EXPECT_PRINTF("393", "%.f", 392.65);
   EXPECT_PRINTF("392.650000", "%F", 392.65);
   EXPECT_PRINTF("392.65", "%s", 392.65);
   char buffer[BUFFER_SIZE];

Original file line number	Diff line number	Diff line change
`@@ -439,6 +439,8 @@ void PrintfFormatter<Char, AF>::format(BasicCStringRef<Char> format_str) {`
`439`	`439`	`} else if (s == '') {`
`440`	`440`	`++s;`
`441`	`441`	`spec.precision_ = internal::PrecisionHandler().visit(get_arg(s));`
	`442`	`+ } else {`
	`443`	`+ spec.precision_ = 0;`
`442`	`444`	`}`
`443`	`445`	`}`
`444`	`446`