Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flytekit] Support extra copy commands in ImageSpec #2715

Merged
merged 30 commits into from
Sep 25, 2024
Merged

[Flytekit] Support extra copy commands in ImageSpec #2715

Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
2f0d516
feat: support building images with extra copy commands
mao3267 Aug 27, 2024
f675359
feat: add `copy` function in ImageSpec
mao3267 Aug 27, 2024
4808d32
test: build image with extra copy cmds
mao3267 Aug 27, 2024
53b859c
test: ImageSpec with extra copy cmds
mao3267 Aug 27, 2024
4f9dafe
fix: f-string syntax error in copy command
mao3267 Aug 27, 2024
76520a0
fix: rename copy function and related arguments
mao3267 Sep 4, 2024
9a9707d
Merge branch 'master' of https://github.com/mao3267/flytekit into add…
mao3267 Sep 4, 2024
e390c51
fix: update image name hash
mao3267 Sep 4, 2024
d1adcee
Merge branch 'master' of https://github.com/mao3267/flytekit into add…
mao3267 Sep 12, 2024
a8bbb1a
fix: update digest with copy files
mao3267 Sep 12, 2024
e2ec68f
feat: support computing digest from list of files
mao3267 Sep 12, 2024
02611de
fix: update image tag
mao3267 Sep 12, 2024
948447e
Merge branch 'master' of https://github.com/mao3267/flytekit into add…
mao3267 Sep 12, 2024
a619773
fix: remove ignore logic
mao3267 Sep 13, 2024
e8545f3
fix: lint
mao3267 Sep 13, 2024
1c46800
fix: add source_copy_node
mao3267 Sep 14, 2024
eca2063
fix: copy local files to tmp_dir for docker copy
mao3267 Sep 17, 2024
dea9233
test: update default builder test and files for copy
mao3267 Sep 17, 2024
954b27b
fix: f-string related error
mao3267 Sep 17, 2024
4d5215c
fix: lint
mao3267 Sep 17, 2024
8f0e3af
feat: support list of strings and strings in `with_copy`
mao3267 Sep 18, 2024
3b4070d
fix: change ImageSpec.copy to list[str]
mao3267 Sep 18, 2024
b2f5659
Merge branch 'master' of https://github.com/mao3267/flytekit into add…
mao3267 Sep 20, 2024
b7e37dd
fix: remain source tree structure
mao3267 Sep 21, 2024
53ddf88
fix: path separator diff on windows
mao3267 Sep 21, 2024
e9b1c96
fix: use update_attribute instead
mao3267 Sep 25, 2024
ff7699f
rm: remove test files
mao3267 Sep 25, 2024
b1ee46a
fix: test with tmp dirs/files
mao3267 Sep 25, 2024
4e347b9
fix: path separator error
mao3267 Sep 25, 2024
a15940d
nit
pingsutw Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: update image name hash 
Signed-off-by: mao3267 <chenvincent610@gmail.com>
  • Loading branch information
@mao3267
mao3267 committed Sep 4, 2024
commit e390c512604c0d6df96246644b50c5b59d8d00fc
2 changes: 1 addition & 1 deletion tests/flytekit/unit/core/image_spec/test_image_spec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def test_image_spec(mock_image_spec_builder, monkeypatch):
assert image_spec.entrypoint == ["/bin/bash"]
assert image_spec.copy == [["/src/file1.txt"], ["/src", "/src/file2.txt"]]

assert image_spec.image_name() == f"localhost:30001/flytekit:lh20ze1E7qsZn5_kBQifRw"
assert image_spec.image_name() == f"localhost:30001/flytekit:Cdsatv_mTV4kwduuC3ul9A"
ctx = context_manager.FlyteContext.current_context()
with context_manager.FlyteContextManager.with_context(
ctx.with_execution_state(ctx.execution_state.with_params(mode=ExecutionState.Mode.TASK_EXECUTION))
Expand Down
Loading