-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker commands in ImageSpec #2676
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: mao3267 <chenvincent610@gmail.com>
Signed-off-by: mao3267 <chenvincent610@gmail.com>
* don't call remote Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * nit Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> --------- Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> Signed-off-by: mao3267 <chenvincent610@gmail.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> Signed-off-by: Kevin Su <pingsutw@apache.org> Co-authored-by: Kevin Su <pingsutw@apache.org> Signed-off-by: mao3267 <chenvincent610@gmail.com>
* Add an exeception when filters' value isn't a list * Make the exception more specific Signed-off-by: Nelson Chen <asd3431090@gmail.com> * add an unit test for value_in Signed-off-by: Nelson Chen <asd3431090@gmail.com> * lint Signed-off-by: Kevin Su <pingsutw@apache.org> --------- Signed-off-by: Nelson Chen <asd3431090@gmail.com> Signed-off-by: Kevin Su <pingsutw@apache.org> Co-authored-by: Kevin Su <pingsutw@apache.org> Signed-off-by: mao3267 <chenvincent610@gmail.com>
Signed-off-by: wayner0628 <a901639@gmail.com> Signed-off-by: Kevin Su <pingsutw@apache.org> Co-authored-by: Kevin Su <pingsutw@apache.org> Signed-off-by: mao3267 <chenvincent610@gmail.com>
* Show different of types in dataclass when transforming error Signed-off-by: Future-Outlier <eric901201@gmail.com> * add tests for dataclass Signed-off-by: Future-Outlier <eric901201@gmail.com> * fix tests Signed-off-by: Future-Outlier <eric901201@gmail.com> --------- Signed-off-by: Future-Outlier <eric901201@gmail.com> Signed-off-by: mao3267 <chenvincent610@gmail.com>
Signed-off-by: mao3267 <chenvincent610@gmail.com>
…an the entire bytes buffer (flyteorg#2641) * pass the local file directly for streaming in FlyteRemote.upload_file Signed-off-by: Reda Oulbacha <reda@artera.ai> * ruff format Signed-off-by: Reda Oulbacha <reda@artera.ai> * add an integration test Signed-off-by: Reda Oulbacha <reda@artera.ai> * remove unnecessary len Signed-off-by: redartera <120470035+redartera@users.noreply.github.com> * redo registration in the integration test Signed-off-by: redartera <120470035+redartera@users.noreply.github.com> * fix misspel Signed-off-by: redartera <120470035+redartera@users.noreply.github.com> * run the integration test serially Signed-off-by: redartera <120470035+redartera@users.noreply.github.com> * disable agent Signed-off-by: Kevin Su <pingsutw@apache.org> * use os.stat instead of os.seek to determine content_length Signed-off-by: redartera <120470035+redartera@users.noreply.github.com> * rewrite tests only uploda a file, use a separate marker Signed-off-by: redartera <120470035+redartera@users.noreply.github.com> * parametrize integration test makefile cmd Signed-off-by: redartera <120470035+redartera@users.noreply.github.com> * add workflow_dispatch for debugging Signed-off-by: redartera <120470035+redartera@users.noreply.github.com> * replace trigger with push Signed-off-by: redartera <120470035+redartera@users.noreply.github.com> * remove trailing whitespaces Signed-off-by: redartera <120470035+redartera@users.noreply.github.com> * remove agent disabling Signed-off-by: redartera <120470035+redartera@users.noreply.github.com> * remove trailing debug CI trigger Signed-off-by: redartera <120470035+redartera@users.noreply.github.com> * clean up botocore imports Signed-off-by: redartera <120470035+redartera@users.noreply.github.com> --------- Signed-off-by: Reda Oulbacha <reda@artera.ai> Signed-off-by: redartera <120470035+redartera@users.noreply.github.com> Signed-off-by: Kevin Su <pingsutw@apache.org> Co-authored-by: Kevin Su <pingsutw@apache.org> Signed-off-by: mao3267 <chenvincent610@gmail.com>
…2652) Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: mao3267 <chenvincent610@gmail.com>
…#2651) Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: mao3267 <chenvincent610@gmail.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> Signed-off-by: mao3267 <chenvincent610@gmail.com>
* return exceptions when gathering Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * pr comment Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> --------- Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> Signed-off-by: mao3267 <chenvincent610@gmail.com>
Signed-off-by: mao3267 <chenvincent610@gmail.com>
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com> Signed-off-by: mao3267 <chenvincent610@gmail.com>
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com> Signed-off-by: mao3267 <chenvincent610@gmail.com>
Signed-off-by: Chen Zhu <chzhu@linkedin.com> Signed-off-by: Chen Zhu <zhuchen1033@gmail.com> Signed-off-by: mao3267 <chenvincent610@gmail.com>
…eorg#2660) * Add repro test case Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Restore loader_args in papermill plugin Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Add unit tests Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> --------- Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: mao3267 <chenvincent610@gmail.com>
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com> Signed-off-by: mao3267 <chenvincent610@gmail.com>
…2665) Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: mao3267 <chenvincent610@gmail.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: mao3267 <chenvincent610@gmail.com>
…-docker-commands
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2676 +/- ##
===========================================
- Coverage 93.48% 80.57% -12.91%
===========================================
Files 17 292 +275
Lines 859 24420 +23561
Branches 0 4009 +4009
===========================================
+ Hits 803 19677 +18874
- Misses 56 4080 +4024
- Partials 0 663 +663 ☔ View full report in Codecov by Sentry. |
Signed-off-by: mao3267 <chenvincent610@gmail.com>
Signed-off-by: mao3267 <chenvincent610@gmail.com>
Signed-off-by: mao3267 <chenvincent610@gmail.com>
Signed-off-by: mao3267 <chenvincent610@gmail.com>
Signed-off-by: mao3267 <chenvincent610@gmail.com>
…-docker-commands
Signed-off-by: mao3267 <chenvincent610@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently the docker context for building is a temporary directory with the files copied over.
@mao3267 Do you think adding DOCKER_COMMANDS
will be confusing in terms of Docker's context? A user may assume that the context is the current working directory.
Why are the changes needed?
We want to support adding other docker commands while creating ImageSpec.
What changes were proposed in this pull request?
How was this patch tested?
It can not use the new ImageSpec while creating a container remotely, therefore, we didn't add test at this time.
We provide an example of building an image.
As the screenshots show, the image is successfully built. However, the task will fail since the flytekit version of the remote container is still
1.13
.Setup process
Screenshots
Check all the applicable boxes
Related PRs
None
Docs link
None