Adds validation to image_spec for parameters that are list of strings #2655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
thomasjpfan
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw,
cosmicBboy,
samhita-alla and
Future-Outlier
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2655 +/- ##
===========================================
- Coverage 92.53% 76.24% -16.29%
===========================================
Files 27 191 +164
Lines 1206 19455 +18249
Branches 0 3780 +3780
===========================================
+ Hits 1116 14834 +13718
- Misses 90 3960 +3870
- Partials 0 661 +661 ☔ View full report in Codecov by Sentry. |
pingsutw
approved these changes
Aug 7, 2024
eapolinario
approved these changes
Aug 8, 2024
mao3267
pushed a commit
to mao3267/flytekit
that referenced
this pull request
Aug 9, 2024
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com> Signed-off-by: mao3267 <chenvincent610@gmail.com>
Mecoli1219
pushed a commit
to Mecoli1219/flytekit
that referenced
this pull request
Aug 14, 2024
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
Mecoli1219
pushed a commit
to Mecoli1219/flytekit
that referenced
this pull request
Aug 14, 2024
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com> Signed-off-by: Mecoli1219 <michaellai901026@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes flyteorg/flyte#5632
Why are the changes needed?
Validation helps users avoid common mistakes.
What changes were proposed in this pull request?
This PR adds validation to all
Optional[List[str]]in `ImageSpecHow was this patch tested?
Unit tests were added to this PR.