Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Add Python 3.9 to build matrix #2622

Merged
merged 23 commits into from
Jul 31, 2024
Merged

ci: Add Python 3.9 to build matrix #2622

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
301e78d
ci: Add Python 3.8 to build matrix
pingsutw Jul 30, 2024
c1d9271
fix test
pingsutw Jul 30, 2024
f37d2af
fix test
pingsutw Jul 30, 2024
ad5c7f8
fix extra
pingsutw Jul 30, 2024
96fe091
update test
pingsutw Jul 30, 2024
096bbaa
Skip tests that use subscripts in `test_type_engine.py` iff running p…
eapolinario Jul 30, 2024
1877919
clearn action cache for integration tests
pingsutw Jul 30, 2024
d9161b3
Use `typing.Tuple` in `test_flyte_pickle.py`
eapolinario Jul 30, 2024
1bf0165
Use `typing_extensions.get_args`
eapolinario Jul 30, 2024
cd12687
Skip `test_guess_dict4` because of its use of `dict`
eapolinario Jul 30, 2024
9563919
Import `Annotated` in `test_dataclass.py`
eapolinario Jul 30, 2024
70278c6
Skip running tests in `test_run.py` that requires `get_entities_in_file`
eapolinario Jul 30, 2024
e2971f0
Fix lint error in `array_node_map_task.py`
eapolinario Jul 30, 2024
05ac951
fix plugins
pingsutw Jul 30, 2024
6d6a9ff
fix tensorflow tests
Future-Outlier Jul 31, 2024
b5754be
push
Future-Outlier Jul 31, 2024
99ade93
fix pytorch plugin
pingsutw Jul 31, 2024
bbd0a96
fix mlflow tests
Future-Outlier Jul 31, 2024
a1a3996
fix unused import
Future-Outlier Jul 31, 2024
208bf2b
fix ray plugin
pingsutw Jul 31, 2024
511ceed
lint
pingsutw Jul 31, 2024
d1933c3
rm mlrun
pingsutw Jul 31, 2024
ba3fc2d
rm mlrun
pingsutw Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Skip tests that use subscripts in test_type_engine.py iff running p… 
…ython 3.8

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
  • Loading branch information
@eapolinario
eapolinario committed Jul 30, 2024
commit 096bbaaeaba8238eba4d89c3c114ec774c00747e
21 changes: 16 additions & 5 deletions tests/flytekit/unit/core/test_type_engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2389,17 +2389,28 @@ class Result(DataClassJsonMixin):
schema: TestSchema # type: ignore


@pytest.mark.parametrize(
"t",
[
def get_unsupported_complex_literals_tests():
if sys.version_info < (3, 9):
return [
typing_extensions.Annotated[typing.Dict[int, str], FlyteAnnotation({"foo": "bar"})],
typing_extensions.Annotated[typing.Dict[str, str], FlyteAnnotation({"foo": "bar"})],
typing_extensions.Annotated[Color, FlyteAnnotation({"foo": "bar"})],
typing_extensions.Annotated[Result, FlyteAnnotation({"foo": "bar"})],
]
return [
typing_extensions.Annotated[dict, FlyteAnnotation({"foo": "bar"})],
typing_extensions.Annotated[dict[int, str], FlyteAnnotation({"foo": "bar"})],
typing_extensions.Annotated[typing.Dict[int, str], FlyteAnnotation({"foo": "bar"})],
typing_extensions.Annotated[dict[str, str], FlyteAnnotation({"foo": "bar"})],
typing_extensions.Annotated[typing.Dict[str, str], FlyteAnnotation({"foo": "bar"})],
typing_extensions.Annotated[Color, FlyteAnnotation({"foo": "bar"})],
typing_extensions.Annotated[Result, FlyteAnnotation({"foo": "bar"})],
],
]


@pytest.mark.parametrize(
"t",
get_unsupported_complex_literals_tests(),
)
def test_unsupported_complex_literals(t):
with pytest.raises(ValueError):
Expand Down Expand Up @@ -3006,7 +3017,7 @@ def test_dataclass_encoder_and_decoder_registry():
class Datum:
x: int
y: str
z: dict[int, int]
z: typing.Dict[int, int]
w: List[int]

@task
Expand Down
Loading