Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Elastic/Artifacts] Pass through model card #2575

Merged
merged 8 commits into from
Jul 29, 2024
Merged

[Elastic/Artifacts] Pass through model card #2575

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ac70b42
loggers
wild-endeavor Jul 9, 2024
f751572
add more logging
wild-endeavor Jul 9, 2024
6d99502
more logging
wild-endeavor Jul 9, 2024
cd3ccfa
add copy
wild-endeavor Jul 9, 2024
40f722d
duh
wild-endeavor Jul 10, 2024
72c3155
remove prints
wild-endeavor Jul 10, 2024
790fde2
remove prints
wild-endeavor Jul 10, 2024
d7bc37b
merge master
wild-endeavor Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove prints 
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
  • Loading branch information
@wild-endeavor
wild-endeavor committed Jul 10, 2024
commit 790fde2bb1946c6df005c8b5059b31c56c8b27be
4 changes: 0 additions & 4 deletions plugins/flytekit-kf-pytorch/flytekitplugins/kfpytorch/task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,11 +256,9 @@ def spawn_helper(
try:
return_val = fn(**kwargs)
omt = ctx.output_metadata_tracker
logger.warning(f"ARTFELASTIC: 1 {omt}")
om = None
if omt:
om = omt.get(return_val)
logger.warning(f"ARTFELASTIC: 2 {om=}")
except Exception as e:
# See explanation in `create_recoverable_error_file` why we check
# for recoverable errors here in the worker processes.
Expand Down Expand Up @@ -445,9 +443,7 @@ def fn_partial():
for deck in out[0].decks:
if not isinstance(deck, flytekit.deck.deck.TimeLineDeck):
ctx.decks.append(deck)
logger.warning(f"ARTFELASTIC: 3 {out[0]}")
if out[0].om:
logger.warning(f"ARTFELASTIC: 4 Adding back {out[0].om}")
ctx.output_metadata_tracker.add(out[0].return_value, out[0].om)

return out[0].return_value
Expand Down
Loading