Skip to content

Commit d1b59c9

Browse files
committed
Use ajv's plural unknown-formats flag
1 parent ec85096 commit d1b59c9

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

ACTIVITY.log.jsonl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,3 +61,4 @@
6161
{"who": "AGENT", "what": "Bulletproofed WHERE parsing", "where": ["tools/log_activity_dispatch.sh"], "when": "2025-10-23T23:55:04Z", "why": "Reviewer caught unquoted expansion breaking spacey paths", "how": "Read space-delimited WHERE into an array, kept newline and JSON paths intact, and left args quoting untouched", "protip": "Prefer read -r -a over bare for-loops when you inherit space-separated env vars"}
6262
{"who": "AGENT", "what": "Keeping compile_commands in sync", "where": ["Makefile"], "when": "2025-10-23T23:55:29Z", "why": "Release build was missing the export flag reviewers expect", "how": "Mirrored -DCMAKE_EXPORT_COMPILE_COMMANDS=ON onto build-release so tooling sees both", "protip": "If you rely on clang-tidy, every build dir needs compile_commands.json"}
6363
{"who": "AGENT", "what": "Taught activity validation about custom formats", "where": ["tools/lint/validate_activity_log.sh"], "when": "2025-10-23T23:56:59Z", "why": "Re-adding format: uri broke ajv until we told it to ignore unknown formats", "how": "Passed --unknown-format ignore to ajv-cli so the schema stays strict while CI stays happy", "protip": "When ajv whines about formats, appease it with the flag instead of dumbing down the schema"}
64+
{"who": "AGENT", "what": "Tweaked the ajv flag spelling", "where": ["tools/lint/validate_activity_log.sh"], "when": "2025-10-23T23:57:38Z", "why": "Turns out the CLI wants --unknown-formats, not --unknown-format", "how": "Swapped the flag and re-ran make activity-validate", "protip": "If a CLI yells about unknown options, double-check the pluralization"}

tools/lint/validate_activity_log.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,6 @@ for entry in "${tmp_dir}"/*.json; do
5050
data_args+=(-d "${entry}")
5151
done
5252

53-
npx --yes ajv-cli@5.0.0 validate --spec=draft7 --unknown-format ignore -s "${schema_file}" "${data_args[@]}" >/dev/null
53+
npx --yes ajv-cli@5.0.0 validate --spec=draft7 --unknown-formats ignore -s "${schema_file}" "${data_args[@]}" >/dev/null
5454

5555
echo "activity-log: validation passed"

0 commit comments

Comments
 (0)