Skip to content

Commit ab46f7a

Browse files
committed
docs: log PR #13 (Mat4 canonical zero + MulAssign) in execution plan and decision log
1 parent f200bf8 commit ab46f7a

File tree

2 files changed

+11
-0
lines changed

2 files changed

+11
-0
lines changed

docs/decision-log.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,3 +17,9 @@
1717
| 2025-10-27 | PR #7 prep | Extracted math + engine spike into `rmg-core` (split-core-math-engine); added inline rustdoc on canonical snapshot hashing (node/edge order, payload encoding). | Land the isolated, reviewable portion now; keep larger geometry/broad‑phase work split for follow-ups. | After docs update, run fmt/clippy/tests; merge is a fast‑forward over `origin/main`. |
1818
| 2025-10-28 | PR #7 finalize | Reachability-only snapshot hashing; ports demo registers rule; guarded ports footprint; scheduler `finalize_tx()` clears `pending`; `PortKey` u30 mask; hooks+CI hardened (toolchain pin, rustdoc fixes). | Determinism + memory hygiene; remove test footguns; pass CI with stable toolchain while keeping rmg-core MSRV=1.68. | Merge PR #7 after green CI; queue MWMR Phase 2 perf tests + retry policy work. |
1919
| 2025-10-27 | MWMR reserve gate | Engine calls `scheduler.finalize_tx()` at commit; compact rule id used on execute path; per‑tx telemetry summary behind feature. | Enforce independence and clear active frontier deterministically; keep ordering stable with `(scope_hash, family_id)`. | Toolchain pinned to Rust 1.68; add design note for telemetry graph snapshot replay. |
20+
## 2025-10-28 — Mat4 canonical zero + MulAssign (PR #13)
21+
22+
- Decision: Normalize -0.0 from trig constructors in Mat4 and add MulAssign for in-place multiplication.
23+
- Rationale: Avoid bitwise drift in snapshot/matrix comparisons across platforms; improve ergonomics in hot loops.
24+
- Impact: No API breaks. New tests assert no -0.0 in rotation matrices at key angles; added `MulAssign` for owned/&rhs.
25+
- Next: Review feedback; if accepted, apply same canonicalization policy to other math where applicable.

docs/execution-plan.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,11 @@ This is Codex’s working map for building Echo. Update it relentlessly—each s
3333

3434
## Today’s Intent
3535

36+
> 2025-10-28 — PR #13 (math polish) opened
37+
38+
- Focus: canonicalize -0.0 in Mat4 trig constructors and add MulAssign ergonomics.
39+
- Outcome: Opened PR echo/core-math-canonical-zero with tests; gather feedback before merge.
40+
3641
> 2025-10-28 — PR #7 finalize and land
3742
3843
- Focus: close out review nits on engine/scheduler/footprint/demo; ensure CI/hook stability; keep scope tight.

0 commit comments

Comments
 (0)