docs(hooks-formatting): update execution plan + decision log; fix pre-commit to run rustfmt without early exit

Author: flyingrobots

.githooks/pre-commit

@@ -2,55 +2,47 @@
 set -euo pipefail
 
 # Enforce coupling between PRNG algorithm/version and golden regression vector.
-
 PRNG_FILE="crates/rmg-core/src/math/prng.rs"
+if git diff --cached --name-only | grep -qx "$PRNG_FILE"; then
+  DIFF=$(git diff --cached -- "$PRNG_FILE" || true)
+  # Heuristics to detect algorithm changes: edits to these functions imply behavior change
+  if echo "$DIFF" | grep -E '^(\+|-)\s*(fn\s+next_u64|fn\s+from_seed_u64|fn\s+from_seed\(|fn\s+next_int\()' >/dev/null; then
+    ALGO_CHANGED=1
+  else
+    ALGO_CHANGED=0
+  fi
 
-# Only run if the PRNG file is staged
-if ! git diff --cached --name-only | grep -qx "$PRNG_FILE"; then
-  exit 0
-fi
-
-DIFF=$(git diff --cached -- "$PRNG_FILE" || true)
-
-# Heuristics to detect algorithm changes: edits to these functions imply behavior change
-if echo "$DIFF" | grep -E '^(\+|-)\s*(fn\s+next_u64|fn\s+from_seed_u64|fn\s+from_seed\(|fn\s+next_int\()' >/dev/null; then
-  ALGO_CHANGED=1
-else
-  ALGO_CHANGED=0
-fi
-
-# Version bump present?
-if echo "$DIFF" | grep -E 'PRNG_ALGO_VERSION' >/dev/null; then
-  VERSION_CHANGED=1
-else
-  VERSION_CHANGED=0
-fi
+  # Version bump present?
+  if echo "$DIFF" | grep -E 'PRNG_ALGO_VERSION' >/dev/null; then
+    VERSION_CHANGED=1
+  else
+    VERSION_CHANGED=0
+  fi
 
-# Golden regression vector updated?
-if echo "$DIFF" | grep -E 'next_int_golden_regression|assert_eq!\(values,\s*vec!\[' >/dev/null; then
-  GOLDEN_CHANGED=1
-else
-  GOLDEN_CHANGED=0
-fi
+  # Golden regression vector updated?
+  if echo "$DIFF" | grep -E 'next_int_golden_regression|assert_eq!\(values,\s*vec!\[' >/dev/null; then
+    GOLDEN_CHANGED=1
+  else
+    GOLDEN_CHANGED=0
+  fi
 
-FAIL=0
-if [[ "$ALGO_CHANGED" -eq 1 && "$VERSION_CHANGED" -eq 0 ]]; then
-  echo "pre-commit: PRNG algorithm changed but PRNG_ALGO_VERSION was not bumped." >&2
-  FAIL=1
-fi
+  FAIL=0
+  if [[ "$ALGO_CHANGED" -eq 1 && "$VERSION_CHANGED" -eq 0 ]]; then
+    echo "pre-commit: PRNG algorithm changed but PRNG_ALGO_VERSION was not bumped." >&2
+    FAIL=1
+  fi
 
-if [[ "$VERSION_CHANGED" -eq 1 && "$GOLDEN_CHANGED" -eq 0 ]]; then
-  echo "pre-commit: PRNG_ALGO_VERSION bumped but golden regression vector was not updated." >&2
-  FAIL=1
-fi
+  if [[ "$VERSION_CHANGED" -eq 1 && "$GOLDEN_CHANGED" -eq 0 ]]; then
+    echo "pre-commit: PRNG_ALGO_VERSION bumped but golden regression vector was not updated." >&2
+    FAIL=1
+  fi
 
-if [[ "$FAIL" -eq 1 ]]; then
-  echo "pre-commit: Refusing commit. Update algorithm version and golden regression together." >&2
-  exit 1
+  if [[ "$FAIL" -eq 1 ]]; then
+    echo "pre-commit: Refusing commit. Update algorithm version and golden regression together." >&2
+    exit 1
+  fi
 fi
 
-exit 0
-
 # Format gate: run rustfmt check if Rust files are staged
 if git diff --cached --name-only | grep -E '\.rs$' >/dev/null; then
   echo "[pre-commit] Running cargo fmt --all -- --check ..."

docs/decision-log.md

@@ -14,3 +14,10 @@
 | 2025-10-26 | EPI bundle | Adopt entropy, plugin, inspector, runtime config specs (Phase 0.75) | Close causality & extensibility gap | Phase 1 implementation backlog defined |
 | 2025-10-26 | RMG + Confluence | Adopt RMG v2 (typed DPOi engine) and Confluence synchronization as core architecture | Unify runtime/persistence/tooling on deterministic rewrites | Launch Rust workspace (rmg-core/ffi/wasm/cli), port ECS rules, set up Confluence networking |
 | 2025-10-27 | Core math split | Split `rmg-core` math into focused submodules (`vec3`, `mat4`, `quat`, `prng`) replacing monolithic `math.rs`. | Improves readability, testability, and aligns with strict linting. | Update imports; no behavior changes intended; follow-up determinism docs in snapshot hashing. |
+
+## 2025-10-29 — Hooks formatting gate (PR #12)
+
+- Context: Enforce consistent formatting before commit; avoid CI/docs drift when non-doc files change.
+- Decision: Pre-commit runs `cargo fmt --all -- --check` whenever staged Rust files are detected. Retain the PRNG coupling guard but remove the unconditional early exit so formatting still runs when the PRNG file isn’t staged.
+- EditorConfig: normalize line endings (LF), ensure final newline, trim trailing whitespace, set 2-space indent for JS/TS/JSON and 4-space for Rust.
+- Consequence: Developers get immediate feedback on formatting; cleaner diffs and fewer CI round-trips.

docs/execution-plan.md

@@ -33,6 +33,12 @@ This is Codex’s working map for building Echo. Update it relentlessly—each s
 
 ## Today’s Intent
 
+> 2025-10-29 — Hooks formatting gate (PR #12)
+
+- Pre-commit: add rustfmt check for staged Rust files (`cargo fmt --all -- --check`).
+- Keep PRNG coupling guard, but avoid early exit so formatting still runs when PRNG file isn't staged.
+- .editorconfig: unify whitespace rules (LF, trailing newline, 2-space for JS/TS, 4-space for Rust).
+
 > 2025-10-27 — Core math modularization (PR #5)
 
 - **Focus**: Split `rmg-core` math into focused submodules (`vec3`, `mat4`, `quat`, `prng`).