Skip to content

helm: Remove TLS tmp dir logic for HelmRepository type: oci#1903

Draft
stefanprodan wants to merge 2 commits intomainfrom
fix-tls-login
Draft

helm: Remove TLS tmp dir logic for HelmRepository type: oci#1903
stefanprodan wants to merge 2 commits intomainfrom
fix-tls-login

Conversation

@stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented Oct 2, 2025 •
edited
Loading

fix: #1902

Tests are now passing on macOS:

--- PASS: TestHelmChartReconciler_reconcileSourceFromOCI_authStrategy/with_contextual_login_provider_and_secretRef (0.96s)
=== RUN   TestHelmChartReconciler_reconcileSourceFromOCI_authStrategy/HTTPS_With_invalid_CA_cert
--- PASS: TestHelmChartReconciler_reconcileSourceFromOCI_authStrategy/HTTPS_With_invalid_CA_cert (0.07s)
=== RUN   TestHelmChartReconciler_reconcileSourceFromOCI_authStrategy/HTTPS_With_CA_cert_only
--- PASS: TestHelmChartReconciler_reconcileSourceFromOCI_authStrategy/HTTPS_With_CA_cert_only (0.09s)
=== RUN   TestHelmChartReconciler_reconcileSourceFromOCI_authStrategy/HTTPS_With_CA_cert_and_client_cert_auth
--- PASS: TestHelmChartReconciler_reconcileSourceFromOCI_authStrategy/HTTPS_With_CA_cert_and_client_cert_auth (0.08s)
--- PASS: TestHelmChartReconciler_reconcileSourceFromOCI_authStrategy (7.00s)

@stefanprodan stefanprodan changed the title helm: Skip setting TLSLoginOption helm: Skip setting TLSLoginOption for HelmRepository type: oci Oct 2, 2025
@stefanprodan stefanprodan force-pushed the fix-tls-login branch 2 times, most recently from 57b1b3d to b266135 Compare October 2, 2025 22:04
@stefanprodan
helm: Remove the TLS tmp dir logic
bcbe7ed 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan
e2e: Delete Bitnami deps
12a1464 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan stefanprodan changed the title helm: Skip setting TLSLoginOption for HelmRepository type: oci helm: Remove TLS tmp dir logic for HelmRepository type: oci Oct 2, 2025
@matheuscscp matheuscscp mentioned this pull request Oct 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Helm chart reconciler tries to login with empty credentials when TLS is set

1 participant

@stefanprodan