-
Notifications
You must be signed in to change notification settings - Fork 209
fix: blob test cores if no error #1808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
bebc98b
to
c74abd6
Compare
Co-authored-by: Shu Kutsuzawa <cappyzawa@gmail.com> Signed-off-by: Terry Howe <terrylhowe@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please rebase and squash, we need to merge a single commit for this |
@@ -115,7 +115,7 @@ func TestNewClientAndBucketExistsWithProxy(t *testing.T) { | |||
|
|||
ok, err := client.BucketExists(context.Background(), "podinfo") | |||
if tt.err != "" { | |||
g.Expect(err.Error()).To(ContainSubstring(tt.err)) | |||
g.Expect(err).To(MatchError(ContainSubstring(tt.err))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
g.Expect(err).To(MatchError(ContainSubstring(tt.err))) | |
g.Expect(err).To(MatchError(ContainSubstring(tt.err))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is blocking the CI
Avoid segment fault if no error