Skip to content

fix: blob test cores if no error #1808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

TerryHowe
Copy link

Avoid segment fault if no error

Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Co-authored-by: Shu Kutsuzawa <cappyzawa@gmail.com>
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Copy link
Member

@matheuscscp matheuscscp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matheuscscp
Copy link
Member

Please rebase and squash, we need to merge a single commit for this

@@ -115,7 +115,7 @@ func TestNewClientAndBucketExistsWithProxy(t *testing.T) {

ok, err := client.BucketExists(context.Background(), "podinfo")
if tt.err != "" {
g.Expect(err.Error()).To(ContainSubstring(tt.err))
g.Expect(err).To(MatchError(ContainSubstring(tt.err)))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
g.Expect(err).To(MatchError(ContainSubstring(tt.err)))
g.Expect(err).To(MatchError(ContainSubstring(tt.err)))

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is blocking the CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants