Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request support for the non-blocking apply method #293

Open
zxbyoyoyo opened this issue Jun 20, 2022 · 4 comments
Open

request support for the non-blocking apply method #293

zxbyoyoyo opened this issue Jun 20, 2022 · 4 comments
Labels
area/server-side-apply SSA related issues and pull requests question Further information is requested

Comments

@zxbyoyoyo
Copy link

We use fluxcd to implement gitops, one application corresponds to one yaml. In use, we found that kustomize-controller will perform dry-run verification on each yaml when executing manifest apply. Once there is a problem with yaml, it will return an error directly. As a result, other normal yaml cannot be executed. See: github.com/fluxcd/pkg/ssa/manager_apply.go:125

We expect that an application yaml has a problem without affecting other application yaml to be applied。
my implementation:
image

@stefanprodan
Copy link
Member

Each application should be reconciled by its own Kustomization, ignoring invalid definitions is not something that I would consider for Flux. You may want to reach out to the others maintainers during Flux dev meetings, write an RFC for this proposal and if the majority of the maintainers vote in favor I will comply with their decision even though I strongly appose it.

@kingdonb kingdonb added question Further information is requested area/server-side-apply SSA related issues and pull requests labels Jun 23, 2022
@aw185176
Copy link

aw185176 commented Jul 8, 2022

While slightly off-topic, it would be fantastic if all the dry run results were collected and returned. Currently our human operators and controllers that leverage fluxcd/pkg/ssa all have to deal with remediations one at a time, then wait for a reconcile or apply loop to finish with the next error.

@stefanprodan
Copy link
Member

@aw185176 is flux diff bailing out at first error? If so then please fill a an issue on the flux2 please.

@aw185176
Copy link

@stefanprodan flux diff works fine, but the dry-run apply that is done by fluxcd/pkg/ssa does bail out on the first dry-run apply erorr: https://github.com/fluxcd/pkg/blob/main/ssa/manager_apply.go#L88. This results in the Kustomization object status only reporting one problem at a time (as well as any of the code that we write using fluxcd/pkg/ssa)

Definitely happy to file a separate issue for that if that is helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/server-side-apply SSA related issues and pull requests question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants