Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timestamps to captured Helm logs #312

Closed
hiddeco opened this issue Aug 10, 2021 · 3 comments · Fixed by #738
Closed

Add timestamps to captured Helm logs #312

hiddeco opened this issue Aug 10, 2021 · 3 comments · Fixed by #738
Assignees
Labels
area/ux In pursuit of a delightful user experience good first issue Good for newcomers

Comments

@hiddeco
Copy link
Member

hiddeco commented Aug 10, 2021

In #219 we started capturing Helm logs, the output at present could however be improved to make it easier to distinguish lines and provide indicators about for example the time it took for a sub action to run.

Current output:

Last Helm logs:

creating 8 resource(s)
beginning wait for 8 resources with timeout of 5m0s
Deployment is not ready: default/myapp-back. 0 out of 1 expected pods are ready

Improved example output:

Last Helm logs:

[<timestamp>] creating 8 resource(s)
[<timestamp>] beginning wait for 8 resources with timeout of 5m0s
[<timestamp>] Deployment is not ready: default/myapp-back. 0 out of 1 expected pods are ready
@hiddeco hiddeco added good first issue Good for newcomers area/ux In pursuit of a delightful user experience labels Aug 10, 2021
@pradeepnnv
Copy link

I would like to give this a try.

@hiddeco
Copy link
Member Author

hiddeco commented Aug 11, 2021

@pradeepnnv all yours, if you need help, just comment here :-).

@peterfication
Copy link

I wanted to give this a try but I'm not sure in which place I would add the timestamps. I would have added them in the LogBuffer.Log method, so that the recorded timestamps match the time they were logged. If I add them in wrapActionError or handleHelmActionResult, all timestamps of the individual captured messages will be the same, which is not what we want here, I assume.

Or maybe I was all wrong and there is another place where it needs to be added? Any hint is appreciated :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ux In pursuit of a delightful user experience good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants