Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement deletion retries #291

Open
dippynark opened this issue Jul 5, 2021 · 2 comments
Open

Implement deletion retries #291

dippynark opened this issue Jul 5, 2021 · 2 comments
Labels
area/helm Helm related issues and pull requests bug Something isn't working

Comments

@dippynark
Copy link

dippynark commented Jul 5, 2021 •
edited
Loading

If a HelmRelease is deleted and fails to delete corresponding resources (e.g. failed webhook or missing CRD) it is never retried and just leaves orphaned resources.

If this functionality is lacking in the Helm Go library this can be accomplished using owner references.
@dippynark dippynark changed the title Retry deletion Implement deletion retries Jul 5, 2021
@kingdonb kingdonb added area/helm Helm related issues and pull requests bug Something isn't working labels Jul 22, 2021
@JaneLiuL
Copy link

I would like to take this issue. Please let me to have a try.

@JaneLiuL JaneLiuL mentioned this issue Jul 28, 2021
Open
@dippynark
Copy link
Author

@JaneLiuL great, after some more thought, I think to do this properly you'll need to inspect the Secrets that Helm uses to store state as mentioned: #292 (comment)

This may require a certain amount of ground work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/helm Helm related issues and pull requests bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kingdonb @dippynark @JaneLiuL