Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Refactor policyMap code #1088

Closed
aaron7 opened this issue May 18, 2018 · 1 comment
Closed

Refactor policyMap code #1088

aaron7 opened this issue May 18, 2018 · 1 comment
Labels
refactor size/small

Comments

@aaron7
Copy link
Contributor

aaron7 commented May 18, 2018

As suggested in https://github.com/weaveworks/flux/pull/1084/files/dff25169bde1e497d4cb644a36ba0224898c2285..617937f1c925bfe6fc726a4ef94017d9927fab97#diff-4adce79060ec85cddf1545ebadcc0d5e

functions like getUnlockedAutomatedServicesPolicyMap and dealing with intersections of policies is getting messy.

Suggested filter functions:

unlockedAutomated := allResources.FilterPolicy(func(policy.Policy) bool {
  return policy.Includes(policy.Automated) && !policy.Includes(policy.Locked)
})
@aaron7 aaron7 mentioned this issue May 18, 2018
Merged
@kingdonb
Copy link
Member

kingdonb commented Apr 6, 2021

Closing. Flux v1 is in Maintenance Mode (see #3320)

@kingdonb kingdonb closed this as completed Apr 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
refactor size/small
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aaron7 @kingdonb