-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Slack bot token authentication #1270
Add support for Slack bot token authentication #1270
Conversation
cb1cd59
to
bff3930
Compare
@RicardoLorenzo can you please document this feature in https://github.com/fluxcd/flagger/blob/main/docs/gitbook/usage/alerting.md Thanks! |
Codecov ReportBase: 54.68% // Head: 54.66% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1270 +/- ##
==========================================
- Coverage 54.68% 54.66% -0.03%
==========================================
Files 81 81
Lines 6965 6972 +7
==========================================
+ Hits 3809 3811 +2
- Misses 2559 2562 +3
- Partials 597 599 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
bff3930
to
a3f290f
Compare
Thank you! documentation added. |
1376bc4
to
b116014
Compare
Signed-off-by: Ricardo Lorenzo <rlorenzo@payfone.com>
b116014
to
3dd667f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @RicardoLorenzo 🎖️ I trust you've tested this with a Slack bot.
Thanks @stefanprodan . I do have a Slack app indeed we used for this. For your peace of mind, this is also referenced in here. The following works which is what we are doing here.
Thanks again! |
Adding Bearer token for using Slack apps instead of webhook as recommended by Slack and also used in Flux.