Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shorten the metric analysis cycle after confirm promotion gate is open #1139

Merged

Conversation

cdlliuy
Copy link
Contributor

@cdlliuy cdlliuy commented Mar 14, 2022

Fix: #1141

@cdlliuy cdlliuy requested a review from stefanprodan as a code owner March 14, 2022 14:33
@cdlliuy cdlliuy force-pushed the ying_short_metric_analysis_waiting_promption branch from 8574e93 to 807353f Compare March 14, 2022 14:34
@cdlliuy cdlliuy force-pushed the ying_short_metric_analysis_waiting_promption branch from 807353f to 11940b6 Compare March 17, 2022 02:29
… and make the analysis check still works during waitingpromption status

Signed-off-by: Ying Liu <ying.liu.lying@gmail.com>
@cdlliuy cdlliuy force-pushed the ying_short_metric_analysis_waiting_promption branch from 11940b6 to ab84ac2 Compare March 17, 2022 02:32
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @cdlliuy 🏅

@stefanprodan stefanprodan added the kind/enhancement Improvement request for an existing feature label Mar 18, 2022
@stefanprodan stefanprodan merged commit 67a2cd6 into fluxcd:main Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvement request for an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long metric analysis cycle when confirm promotion gate is open
2 participants