Use the primary replicas when scaling up the canary (no hpa)

[Moscagus]

If HPA isn't set and "spec.replicas" are not specified in the canary, it uses the primary replicas when scaling up the canary.
Therefore when the promotion ends, primary deployment is left with the correct number of pods and not 1 pod.

Note: The fix "Set primary deployment replicas when autoscaler isn't used #1106" requires that "spec.replicas" be set in each new canary deploy, otherwise at the end of the promotion the primary deploy is left with only 1 pod.

Signed-off-by: Moscagus gustavo.varisco@gmail.com

[stefanprodan]

LGTM

Thanks @Moscagus

[codecov-commenter]

Codecov Report

Merging #1110 (f7fd6cc) into main (cf8fe94) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #1110   +/-   ##
=======================================
  Coverage   57.21%   57.22%           
=======================================
  Files          78       78           
  Lines        6344     6350    +6     
=======================================
+ Hits         3630     3634    +4     
  Misses       2172     2172           
- Partials      542      544    +2     

Impacted Files	Coverage Δ
pkg/canary/deployment_controller.go	62.87% <0.00%> (-1.51%)	⬇️
pkg/loadtester/server.go	12.50% <0.00%> (-0.45%)	⬇️
pkg/loadtester/helmv3.go	0.00% <0.00%> (ø)
pkg/loadtester/helm.go
pkg/loadtester/authorizer.go	100.00% <0.00%> (ø)
pkg/controller/finalizer.go	37.66% <0.00%> (+0.82%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf8fe94...f7fd6cc. Read the comment docs.