Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the secret for the metric provider should be less impactful #1708

Open
AlainDeleglise opened this issue Oct 3, 2024 · 2 comments
Open

Comments

@AlainDeleglise
Copy link

Describe the feature

When one uses an external metric provider for the metric templates, changing the secret can only be done by deleting and recreating the canary object, which in turn results in the deletion of the target object (and related pods).

Proposed solution

The external metric provider secret should be decoupled from the canary object, to allow one to make secret rotation or just plain changing the secret.

Any alternatives you've considered?

Maybe mount the secret in the flagger pod, when one deploys it as a replicas, a rollout has no impact.

@aryan9600
Copy link
Member

the metric provider secret is decoupled from the canary object, if you use the MetricTemplate API: https://docs.flagger.app/usage/metrics#custom-metrics

@AlainDeleglise
Copy link
Author

AlainDeleglise commented Oct 28, 2024

@aryan9600 Hi, thanks for your answer. I've already specified the secret in the metric template object. However, I've tried to just delete the metric template and recreate it, but flagger is still unable to collect the metrics, hence my message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants