Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C/C++ for a "MatchSatisfy" or "Satisfies" function #1118

Closed
vsoch opened this issue Dec 14, 2023 · 2 comments
Closed

C/C++ for a "MatchSatisfy" or "Satisfies" function #1118

vsoch opened this issue Dec 14, 2023 · 2 comments

Comments

@vsoch
Copy link
Member

vsoch commented Dec 14, 2023

From my notes:

We don't have support for that in the C/C++ API - need Go binding for MatchSatisfy Satisfies.

Basically, we want a function (akin to match) that is just for Satisfies. This might be related to #1115 if the intention here was not to add another argument there, but to create a separate function (and not have to deal with changing the defaults / backwards compatibility stuff). After we have this in C/C++ I should be good to write the Go binding for it.

@zekemorton @milroy hopefully this issue is the easiest one! Thanks for the meeting today, it's fun to learn more / talk about flux-sched.

@trws
Copy link
Member

trws commented Jul 31, 2024

What's missing here? I would have expected match_allocate with a "satisfies" match type would do it.

@vsoch
Copy link
Member Author

vsoch commented Jul 31, 2024

This was written before we had that I think - December 2023, and added February this year!

19270a3

Good to close (and really happy to ahve this) - nice work @zekemorton !

@vsoch vsoch closed this as completed Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants