From 1e53cd0d6a0d53a4f459b2cf7c61da808bdc68ab Mon Sep 17 00:00:00 2001 From: Seba Perez Date: Tue, 2 Jun 2020 16:05:03 -0300 Subject: [PATCH] Change on eplanning endpoint (#1327) --- adapters/eplanning/eplanning.go | 1 - adapters/eplanning/eplanning_test.go | 2 +- adapters/eplanning/eplanningtest/exemplary/simple-banner-2.json | 2 +- adapters/eplanning/eplanningtest/exemplary/simple-banner.json | 2 +- adapters/eplanning/eplanningtest/exemplary/two-banners.json | 2 +- .../supplemental/app-domain-and-url-correctly-parsed.json | 2 +- .../eplanningtest/supplemental/banner-no-size-sends-1x1.json | 2 +- .../eplanningtest/supplemental/invalid-response-no-bids.json | 2 +- .../supplemental/invalid-response-unmarshall-error.json | 2 +- .../eplanningtest/supplemental/server-bad-request.json | 2 +- .../eplanning/eplanningtest/supplemental/server-error-code.json | 2 +- .../eplanning/eplanningtest/supplemental/server-no-content.json | 2 +- .../supplemental/site-domain-and-url-correctly-parsed.json | 2 +- config/config.go | 2 +- 14 files changed, 13 insertions(+), 14 deletions(-) diff --git a/adapters/eplanning/eplanning.go b/adapters/eplanning/eplanning.go index 5fb9ccf27c2..2a46b5469e0 100644 --- a/adapters/eplanning/eplanning.go +++ b/adapters/eplanning/eplanning.go @@ -133,7 +133,6 @@ func (adapter *EPlanningAdapter) MakeRequests(request *openrtb.BidRequest, reqIn uriObj.Path = uriObj.Path + fmt.Sprintf("/%s/%s/%s/%s", clientID, dfpClientID, requestTarget, sec) query := url.Values{} - query.Set("r", "pbs") query.Set("ncb", "1") if request.App == nil { query.Set("ur", pageURL) diff --git a/adapters/eplanning/eplanning_test.go b/adapters/eplanning/eplanning_test.go index d2c331d456d..461fb849ced 100644 --- a/adapters/eplanning/eplanning_test.go +++ b/adapters/eplanning/eplanning_test.go @@ -8,7 +8,7 @@ import ( ) func TestJsonSamples(t *testing.T) { - eplanningAdapter := NewEPlanningBidder(new(http.Client), "https://ads.us.e-planning.net/hb/1") + eplanningAdapter := NewEPlanningBidder(new(http.Client), "https://ads.us.e-planning.net/pbs/1") eplanningAdapter.testing = true adapterstest.RunJSONBidderTest(t, "eplanningtest", eplanningAdapter) } diff --git a/adapters/eplanning/eplanningtest/exemplary/simple-banner-2.json b/adapters/eplanning/eplanningtest/exemplary/simple-banner-2.json index e602877f27f..a67a86d18e6 100644 --- a/adapters/eplanning/eplanningtest/exemplary/simple-banner-2.json +++ b/adapters/eplanning/eplanningtest/exemplary/simple-banner-2.json @@ -28,7 +28,7 @@ "httpCalls": [ { "expectedRequest": { - "uri": "https://ads.us.e-planning.net/hb/1/12345/1/FILE/ROS?e=300x250%3A300x250&ncb=1&r=pbs&ur=FILE", + "uri": "https://ads.us.e-planning.net/pbs/1/12345/1/FILE/ROS?e=300x250%3A300x250&ncb=1&ur=FILE", "body": {} }, "mockResponse": { diff --git a/adapters/eplanning/eplanningtest/exemplary/simple-banner.json b/adapters/eplanning/eplanningtest/exemplary/simple-banner.json index 0403e59a763..9146bb4afb5 100644 --- a/adapters/eplanning/eplanningtest/exemplary/simple-banner.json +++ b/adapters/eplanning/eplanningtest/exemplary/simple-banner.json @@ -31,7 +31,7 @@ "httpCalls": [ { "expectedRequest": { - "uri": "https://ads.us.e-planning.net/hb/1/12345/1/FILE/ROS?e=testadun_itco_de%3A600x300&ip=123.123.123.123&ncb=1&r=pbs&uid=2154987&ur=FILE", + "uri": "https://ads.us.e-planning.net/pbs/1/12345/1/FILE/ROS?e=testadun_itco_de%3A600x300&ip=123.123.123.123&ncb=1&uid=2154987&ur=FILE", "body": {} }, "mockResponse": { diff --git a/adapters/eplanning/eplanningtest/exemplary/two-banners.json b/adapters/eplanning/eplanningtest/exemplary/two-banners.json index 8c4ca0214db..174c8ce3fc6 100644 --- a/adapters/eplanning/eplanningtest/exemplary/two-banners.json +++ b/adapters/eplanning/eplanningtest/exemplary/two-banners.json @@ -39,7 +39,7 @@ "httpCalls": [ { "expectedRequest": { - "uri": "https://ads.us.e-planning.net/hb/1/12345/1/FILE/ROS?e=testadunitcode%3A600x300%2B300x250%3A300x250&ip=123.123.123.123&ncb=1&r=pbs&ur=FILE", + "uri": "https://ads.us.e-planning.net/pbs/1/12345/1/FILE/ROS?e=testadunitcode%3A600x300%2B300x250%3A300x250&ip=123.123.123.123&ncb=1&ur=FILE", "body": {} }, "mockResponse": { diff --git a/adapters/eplanning/eplanningtest/supplemental/app-domain-and-url-correctly-parsed.json b/adapters/eplanning/eplanningtest/supplemental/app-domain-and-url-correctly-parsed.json index e6e25566b6a..04df82f6668 100644 --- a/adapters/eplanning/eplanningtest/supplemental/app-domain-and-url-correctly-parsed.json +++ b/adapters/eplanning/eplanningtest/supplemental/app-domain-and-url-correctly-parsed.json @@ -39,7 +39,7 @@ "httpCalls": [ { "expectedRequest": { - "uri": "https://ads.us.e-planning.net/hb/1/12345/1/mx.com.xeu/ROS?app=1&appid=%5Ba-f0-9%5D%7B16%7D&appn=MobileExchange&e=testadunitcode%3A600x300&ifa=3B8E2335-Z049&ip=123.123.123.123&ncb=1&r=pbs", + "uri": "https://ads.us.e-planning.net/pbs/1/12345/1/mx.com.xeu/ROS?app=1&appid=%5Ba-f0-9%5D%7B16%7D&appn=MobileExchange&e=testadunitcode%3A600x300&ifa=3B8E2335-Z049&ip=123.123.123.123&ncb=1", "body": {} }, "mockResponse": { diff --git a/adapters/eplanning/eplanningtest/supplemental/banner-no-size-sends-1x1.json b/adapters/eplanning/eplanningtest/supplemental/banner-no-size-sends-1x1.json index f1bc29e1afc..f02eb80fe41 100644 --- a/adapters/eplanning/eplanningtest/supplemental/banner-no-size-sends-1x1.json +++ b/adapters/eplanning/eplanningtest/supplemental/banner-no-size-sends-1x1.json @@ -19,7 +19,7 @@ "httpCalls": [ { "expectedRequest": { - "uri": "https://ads.us.e-planning.net/hb/1/12345/1/FILE/ROS?e=testadunitcodenosize%3A1x1&ncb=1&r=pbs&ur=FILE", + "uri": "https://ads.us.e-planning.net/pbs/1/12345/1/FILE/ROS?e=testadunitcodenosize%3A1x1&ncb=1&ur=FILE", "body": {} }, "mockResponse": { diff --git a/adapters/eplanning/eplanningtest/supplemental/invalid-response-no-bids.json b/adapters/eplanning/eplanningtest/supplemental/invalid-response-no-bids.json index 978989e295f..8bdcfddd733 100644 --- a/adapters/eplanning/eplanningtest/supplemental/invalid-response-no-bids.json +++ b/adapters/eplanning/eplanningtest/supplemental/invalid-response-no-bids.json @@ -21,7 +21,7 @@ "httpCalls": [ { "expectedRequest": { - "uri": "https://ads.us.e-planning.net/hb/1/12345/1/FILE/ROS?e=testadunitcode%3A600x300&ncb=1&r=pbs&ur=FILE", + "uri": "https://ads.us.e-planning.net/pbs/1/12345/1/FILE/ROS?e=testadunitcode%3A600x300&ncb=1&ur=FILE", "body": {} }, "mockResponse": { diff --git a/adapters/eplanning/eplanningtest/supplemental/invalid-response-unmarshall-error.json b/adapters/eplanning/eplanningtest/supplemental/invalid-response-unmarshall-error.json index 7198f4ee117..9f5b2d7fc03 100644 --- a/adapters/eplanning/eplanningtest/supplemental/invalid-response-unmarshall-error.json +++ b/adapters/eplanning/eplanningtest/supplemental/invalid-response-unmarshall-error.json @@ -21,7 +21,7 @@ "httpCalls": [ { "expectedRequest": { - "uri": "https://ads.us.e-planning.net/hb/1/12345/1/FILE/ROS?e=testadunitcode%3A600x300&ncb=1&r=pbs&ur=FILE", + "uri": "https://ads.us.e-planning.net/pbs/1/12345/1/FILE/ROS?e=testadunitcode%3A600x300&ncb=1&ur=FILE", "body": {} }, "mockResponse": { diff --git a/adapters/eplanning/eplanningtest/supplemental/server-bad-request.json b/adapters/eplanning/eplanningtest/supplemental/server-bad-request.json index 938ede62664..2ef03648884 100644 --- a/adapters/eplanning/eplanningtest/supplemental/server-bad-request.json +++ b/adapters/eplanning/eplanningtest/supplemental/server-bad-request.json @@ -21,7 +21,7 @@ "httpCalls": [ { "expectedRequest": { - "uri": "https://ads.us.e-planning.net/hb/1/12345/1/FILE/ROS?e=testadunitcode%3A600x300&ncb=1&r=pbs&ur=FILE", + "uri": "https://ads.us.e-planning.net/pbs/1/12345/1/FILE/ROS?e=testadunitcode%3A600x300&ncb=1&ur=FILE", "body": {} }, "mockResponse": { diff --git a/adapters/eplanning/eplanningtest/supplemental/server-error-code.json b/adapters/eplanning/eplanningtest/supplemental/server-error-code.json index eaa2a677f93..76e75a5c203 100644 --- a/adapters/eplanning/eplanningtest/supplemental/server-error-code.json +++ b/adapters/eplanning/eplanningtest/supplemental/server-error-code.json @@ -21,7 +21,7 @@ "httpCalls": [ { "expectedRequest": { - "uri": "https://ads.us.e-planning.net/hb/1/12345/1/FILE/ROS?e=testadunitcode%3A600x300&ncb=1&r=pbs&ur=FILE", + "uri": "https://ads.us.e-planning.net/pbs/1/12345/1/FILE/ROS?e=testadunitcode%3A600x300&ncb=1&ur=FILE", "body": {} }, "mockResponse": { diff --git a/adapters/eplanning/eplanningtest/supplemental/server-no-content.json b/adapters/eplanning/eplanningtest/supplemental/server-no-content.json index d1feb865f0d..02f1fa46d33 100644 --- a/adapters/eplanning/eplanningtest/supplemental/server-no-content.json +++ b/adapters/eplanning/eplanningtest/supplemental/server-no-content.json @@ -21,7 +21,7 @@ "httpCalls": [ { "expectedRequest": { - "uri": "https://ads.us.e-planning.net/hb/1/12345/1/FILE/ROS?e=testadunitcode%3A600x300&ncb=1&r=pbs&ur=FILE", + "uri": "https://ads.us.e-planning.net/pbs/1/12345/1/FILE/ROS?e=testadunitcode%3A600x300&ncb=1&ur=FILE", "body": {} }, "mockResponse": { diff --git a/adapters/eplanning/eplanningtest/supplemental/site-domain-and-url-correctly-parsed.json b/adapters/eplanning/eplanningtest/supplemental/site-domain-and-url-correctly-parsed.json index 2f43b9aac2f..581cb1d5b46 100644 --- a/adapters/eplanning/eplanningtest/supplemental/site-domain-and-url-correctly-parsed.json +++ b/adapters/eplanning/eplanningtest/supplemental/site-domain-and-url-correctly-parsed.json @@ -25,7 +25,7 @@ "httpCalls": [ { "expectedRequest": { - "uri": "https://ads.us.e-planning.net/hb/1/12345/1/www.publisher.com/ROS?e=testadunitcode%3A600x300&ncb=1&r=pbs&ur=http%3A%2F%2Fwww.publisher.com%2Fawesome%2Fsite%3Fwith%3Dsome%26parameters%3Dhere", + "uri": "https://ads.us.e-planning.net/pbs/1/12345/1/www.publisher.com/ROS?e=testadunitcode%3A600x300&ncb=1&ur=http%3A%2F%2Fwww.publisher.com%2Fawesome%2Fsite%3Fwith%3Dsome%26parameters%3Dhere", "body": {} }, "mockResponse": { diff --git a/config/config.go b/config/config.go index 3b34d3a4815..79a31db154a 100755 --- a/config/config.go +++ b/config/config.go @@ -718,7 +718,7 @@ func SetupViper(v *viper.Viper, filename string) { v.SetDefault("adapters.datablocks.endpoint", "http://{{.Host}}/openrtb2?sid={{.SourceId}}") v.SetDefault("adapters.emx_digital.endpoint", "https://hb.emxdgt.com") v.SetDefault("adapters.engagebdr.endpoint", "http://dsp.bnmla.com/hb") - v.SetDefault("adapters.eplanning.endpoint", "https://ads.us.e-planning.net/hb/1") + v.SetDefault("adapters.eplanning.endpoint", "https://ads.us.e-planning.net/pbs/1") v.SetDefault("adapters.gamma.endpoint", "https://hb.gammaplatform.com/adx/request/") v.SetDefault("adapters.gamoshi.endpoint", "https://rtb.gamoshi.io") v.SetDefault("adapters.grid.endpoint", "http://grid.bidswitch.net/sp_bid?sp=prebid")