fix(connectivity_plus): Improve iOS PathMonitorConnectivityProvider implementation and documentation #2763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbuberen
approved these changes
Mar 28, 2024
hantrungkien
pushed a commit
to hantrungkien/graphql-flutter
that referenced
this pull request
May 27, 2024
2 important commits: v6.0.2: fluttercommunity/plus_plugins#2763 v6.0.3: fluttercommunity/plus_plugins#2836
hantrungkien
pushed a commit
to hantrungkien/graphql-flutter
that referenced
this pull request
May 27, 2024
2 important commits: v6.0.2: fluttercommunity/plus_plugins#2763 v6.0.3: fluttercommunity/plus_plugins#2836
hantrungkien
added a commit
to hantrungkien/graphql-flutter
that referenced
this pull request
May 27, 2024
2 important commits: v6.0.2: fluttercommunity/plus_plugins#2763 v6.0.3: fluttercommunity/plus_plugins#2836
hantrungkien
added a commit
to hantrungkien/graphql-flutter
that referenced
this pull request
May 27, 2024
2 important commits: v6.0.2: fluttercommunity/plus_plugins#2763 v6.0.3: fluttercommunity/plus_plugins#2836
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a couple of code changes:
DispatchQueue"Quality of Service" from.backgroundto.utility, as per documentation seems like a better choice.pathUpdateHandlerhas been modified to use the providedpathinstead of using the storedcurrentPathin the path monitor. This may make a difference when it comes to obtaining reliable connectivity change updates. The code has been refactored to reuse the existing method.As well, I have updated the README.md with some information regarding the iOS implementation and its limitations.
Related Issues
Checklist
CHANGELOG.mdnor the plugin version inpubspec.yamlfiles.flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!in the title as explained in Conventional Commits).