Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isReady swallows errors from async factories #300

Closed
kuhnroyal opened this issue Nov 3, 2022 · 1 comment
Closed

isReady swallows errors from async factories #300

kuhnroyal opened this issue Nov 3, 2022 · 1 comment

Comments

@kuhnroyal
Copy link
Contributor

When an instance is registered with registerSingletonAsync<T> and later checked if it is ready with isReady<T>(), then errors occurring inside the async factory function are swallowed/lost.

A workaround is to use getAsync<T>() instead where errors are correctly propagated.
@escamoteur
Copy link
Collaborator

Good catch, fixed in V7.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kuhnroyal @escamoteur