This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
remove unnecessary new from samples #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Analysis issues around constructor order are also showing up in head, and look related to a Dart roll, not this PR. |
|
LGTM, but let's get the CI job working in head before we merge this |
|
cc @cbracken is someone looking at the CI issue? |
|
I'm fixing the CI issues. |
a14n
force-pushed
the
unnecessary_new_sample
branch
from
84e34e5
to
ffbf999
Compare
|
As the build failures are now the same as in master (and as this PR only touch READMEs and docs) I'm tempted to merge this PR. WDYT? |
|
@cbracken can we land this? |
4 tasks
|
Merging as CI is passing now |
|
Thanks |
|
@a14n looks like the CI job failed after the merge; does this look related to your changes? |
|
I don't think it's related to my PR (only README and comments had been changed). |
andreidiaconu
pushed a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
andreidiaconu
added a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
This reverts commit 5d07373.
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
Akachu
pushed a commit
to Akachu/flutter_camera
that referenced
this pull request
Apr 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.