Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[plugins] Disables the AndroidGradlePluginVersion issue ID in all android packages #7045

Merged
merged 5 commits into from
Feb 19, 2023

Conversation

FXschwartz
Copy link
Contributor

@FXschwartz FXschwartz commented Jan 27, 2023

Disables the AndroidGradlePluginVersion issue ID in each Android package to prevent a gradle version warning from showing up in Github UI.

List which issues are fixed by this PR. You must list at least one issue.
Fixes - flutter/flutter#95048

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy. N/A

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@Hixie
Copy link
Contributor

Hixie commented Jan 27, 2023

test-exempt: configuration change

@stuartmorgan stuartmorgan added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Jan 30, 2023
@stuartmorgan
Copy link
Contributor

Overriding version and changelog checks, since these are dev-only changes and thus exempt per repo policy.

Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up! LGTM once the changelogs are reverted.

packages/camera/camera_android/CHANGELOG.md Outdated Show resolved Hide resolved
@reidbaker reidbaker requested review from reidbaker and removed request for GaryQian February 9, 2023 19:23
@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 19, 2023
@auto-submit auto-submit bot merged commit 1acaf55 into flutter:main Feb 19, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 20, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 20, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 20, 2023
* 3c7d54bba [camerax] Implement camera preview (flutter/plugins#7112)

* 48f50b4f1 [image_picker] Update NSPhotoLibraryUsageDescription description in README (flutter/plugins#6589)

* eea17c996 Migrate these tests to the "new" API. (flutter/plugins#7189)

* 190c6d916 Roll Flutter from 298d8c7 to 0be7c3f (21 revisions) (flutter/plugins#7194)

* c0d4e8041 [google_sign_in] Endorses next web package. (flutter/plugins#7191)

* cc4eaba0f [google_maps]: Bump org.mockito:mockito-core (flutter/plugins#7099)

* 717a8bfef [image_picker]: Bump org.mockito:mockito-core (flutter/plugins#7097)

* 8a09d8c13 [lifecycle]: Bump org.mockito:mockito-core (flutter/plugins#7096)

* 40377a12a [in_app_pur]: Bump org.mockito:mockito-core (flutter/plugins#7094)

* 6a4bbf1df [url_launcher]: Bump org.mockito:mockito-core (flutter/plugins#7098)

* 96ab5cd12 Update codeowners (flutter/plugins#7188)

* 00d5855cc Add missing CODEOWNER (flutter/plugins#7016)

* c3e9d1ba3 [webview_flutter] Adds examples of accessing platform-specific features for each class (flutter/plugins#7089)

* 1f7b57917 Roll Flutter from 0be7c3f to 33e4d21 (5 revisions) (flutter/plugins#7196)

* 1acaf55c2 [plugins] Disables the AndroidGradlePluginVersion issue ID in all android packages (flutter/plugins#7045)

* 132d9c77d [espresso] Update some dependencies (flutter/plugins#7195)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants