This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[webview_flutter] Implementation of the app facing WebViewController for v4 #6280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
p: webview_flutter
bparrishMines
changed the title
bparrishMines
added
override: no versioning needed
packages/webview_flutter/webview_flutter/lib/src/v4/src/webview_controller.dart
Show resolved
Hide resolved
| /// The following caches are cleared: | ||
| /// 1. Browser HTTP Cache. | ||
| /// 2. [Cache API](https://developers.google.com/web/fundamentals/instant-and-offline/web-storage/cache-api) caches. | ||
| /// These are not yet supported in iOS WkWebView. Service workers tend to |
Contributor
There was a problem hiding this comment.
Referencing WkWebView is probably too much of an internal implementation detail for a client-facing API.
| return platform.getTitle(); | ||
| } | ||
|
|
||
| /// Set the scrolled position of this view. |
Contributor
There was a problem hiding this comment.
We should use a consistent verb form, so this should be "Sets". Most of the methods after this point need the same change.
stuartmorgan-g
approved these changes
Sep 1, 2022
Contributor
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Oops, I meant to change this to an approval when I left that last comment, since that was my only real concern. LGTM.
bparrishMines
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/plugins, pr: 6280, Failed to merge pr#: 6280 with OperationException(linkException: null, graphqlErrors: [GraphQLError(message: Base branch was modified. Review and try the merge again., locations: [ErrorLocation(line: 2, column: 3)], path: [mergePullRequest], extensions: null)]). |
bparrishMines
added
autosubmit
bparrishMines
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 8, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 8, 2022
adam-harwood
pushed a commit
to adam-harwood/flutter_plugins
that referenced
this pull request
Nov 3, 2022
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of flutter/flutter#94051
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.