-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
No need to update version because all the files are test files |
You'll need to include the roll in this so that |
Flutter roll included: #6235 |
test-exempt: reformat |
Not sure why |
Looks like a Cirrus bug. I filed cirruslabs/cirrus-ci-docs#1054 If we don't have a fix on Monday I'll just revert the debugging here and we can force-land this. |
Landing manually since the Cirrus issue is not resolved yet. |
Apply new format rules to some dart files. This fixes the flutter -> plugin roll
Apply new format rules to some dart files. This fixes the flutter -> plugin roll
Apply new format rules to some dart files.
This fixes the flutter -> plugin roll
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.