Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[flutter_plugin_tools] Preserve Dart SDK version in all-plugins-app #5281

Merged

Conversation

stuartmorgan-g
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g commented Apr 15, 2022

Fixes all-plugins-app to preserve the original application's Dart SDK version to avoid changing language feature opt-ins that the template may rely on.

Unblocks the master roller, manually rolling to the version that adopted super parameters as validation.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

Fixes `all-plugins-app` to preserve the original application's Dart SDK
version to avoid changing language feature opt-ins that the template may
rely on.

Should unblock the `master` roller.
@ditman
Copy link
Member

ditman commented Apr 15, 2022

Landing this to restart the roller

@ditman ditman merged commit c0bc7cc into flutter:main Apr 15, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 18, 2022
@stuartmorgan-g stuartmorgan-g deleted the build-all-plugins-floating-sdk-version branch April 18, 2022 16:38
LoPat-Airgram pushed a commit to mindcruiser/plugins that referenced this pull request Apr 19, 2022
* master: (153 commits)
  Roll Flutter from fd360c4 to ef5a6da (1 revision) (flutter#5298)
  [video_player_avfoundation] Applies the standardized transform for videos with different orientations (flutter#5069)
  Roll Flutter from 3752fb7 to fd360c4 (2 revisions) (flutter#5295)
  Roll Flutter from 3c4d7a1 to 3752fb7 (11 revisions) (flutter#5294)
  Add owners for Android implementations (flutter#5293)
  Roll Flutter from f4875ae to 3c4d7a1 (2 revisions) (flutter#5292)
  [video_player_web] Stop buffering when browser canPlayThrough. (flutter#5068)
  Roll Flutter from aa5d7b6 to f4875ae (1 revision) (flutter#5289)
  Roll Flutter from 44be0b8 to aa5d7b6 (12 revisions) (flutter#5286)
  Roll Flutter from ec8289c to 44be0b8 (2 revisions) (flutter#5284)
  Roll Flutter from 329ceae to ec8289c (26 revisions) (flutter#5283)
  [flutter_plugin_tools] Preserve Dart SDK version in all-plugins-app (flutter#5281)
  [webview_flutter_wkwebview] Implements the `HostApis` and methods for the `CookieManager`. (flutter#5244)
  [webview_flutter_wkwebview] Implement `WKNavigationDelegate.didFinishNavigation` as a proof of concept for callback methods (flutter#5199)
  Roll Flutter from 08e467d to 2b83332 (5 revisions) (flutter#5270)
  Roll Flutter from e2d1206 to 08e467d (1 revision) (flutter#5268)
  Roll Flutter from ff9d6e5 to e2d1206 (2 revisions) (flutter#5266)
  Roll Flutter from 0575932 to ff9d6e5 (1 revision) (flutter#5265)
  [local_auth] Refactor package to make use of new platform interface and native implementations (flutter#4701)
  Roll Flutter from cb968c5 to 0575932 (1 revision) (flutter#5263)
  ...
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
…lutter#5281)

Fixes `all-plugins-app` to preserve the original application's Dart SDK
version to avoid changing language feature opt-ins that the template may
rely on.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants