Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[webview_flutter] Resolve _CastError thrown by example app. #4390

Merged
merged 2 commits into from
Sep 28, 2021
Merged

[webview_flutter] Resolve _CastError thrown by example app. #4390

merged 2 commits into from
Sep 28, 2021

Conversation

mvanbeusekom
Copy link
Contributor

This PR solves the _CastError that is being thrown by the example app when it is loading the NavigationControls widget.

This PR makes sure the navigation controls in the example App are loaded immediately, but only enable when the WebViewController is available.

Fixes flutter/flutter#90597

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label Sep 28, 2021
@github-actions github-actions bot added the p: webview_flutter Edits files for a webview_flutter plugin label Sep 28, 2021
BeMacized
BeMacized approved these changes Sep 28, 2021
View reviewed changes
Copy link
Contributor

@BeMacized BeMacized left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvanbeusekom mvanbeusekom added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Sep 28, 2021
@fluttergithubbot fluttergithubbot merged commit 4470692 into flutter:master Sep 28, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 28, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 28, 2021
@engine-flutter-autoroll
4470692 Fixed _CastError when running example App (flutter/plugins#4390)
6dcd04a
fluttergithubbot pushed a commit to flutter/flutter that referenced this pull request Sep 28, 2021
@engine-flutter-autoroll
4470692 Fixed _CastError when running example App (flutter/plugins#4390…
effbc14 
…) (#90871)
NickalasB added a commit to NickalasB/plugins that referenced this pull request Sep 30, 2021
@NickalasB
Merge branch 'master' into add_zoom_to_android_webview
bdb07f7 
* master:
  [google_maps_flutter] Add Marker drag events (flutter#2838)
  [flutter_plugin_tools] Validate pubspec description (flutter#4396)
  Add file_selector to the repo list (flutter#4395)
  [in_app_purchase] Fix in_app_purchase_android/README.md (flutter#4363)
  [google_maps_flutter_web] Add Marker drag events (flutter#4385)
  [webview_flutter] Fixed todos in FlutterWebView.java (flutter#4394)
  Handle `PurchaseStatus.restored` correctly in example. (flutter#4393)
  Handle restored purchases in iOS example app (flutter#4392)
  [file_selector] Remove custom analysis options (flutter#4382)
  [flutter_plugin_tools] Check licenses in Kotlin (flutter#4373)
  Fixed _CastError when running example App (flutter#4390)
  [in_app_purchase] Ensure the introductoryPriceMicros field is transported as a String. (flutter#4370)
  Load navigation controls immediately. (flutter#4377)
  [camera] Fix IllegalStateException being thrown in Android implementation when switching activities. (flutter#4319)

# Conflicts:
#	packages/webview_flutter/webview_flutter/CHANGELOG.md
#	packages/webview_flutter/webview_flutter_android/CHANGELOG.md
mgonzalezc pushed a commit to mgonzalezc/plugins that referenced this pull request Oct 12, 2021
Merge branch 'master' into quick_actions_mindapps
419b195 
* master: (1126 commits)
  [webview_flutter] Adjust test URLs again (flutter#4407)
  [google_sign_in] Add serverAuthCode attribute to google_sign_in_platform_interface user data (flutter#4179)
  [camera] Add filter for unsupported cameras on Android (flutter#4418)
  [webview_flutter] Update webview platform interface with new methods for running JavaScript. (flutter#4401)
  [webview_flutter] Add zoomEnabled to webview flutter platform interface (flutter#4404)
  [ci] Remove obsolete Dockerfile (flutter#4405)
  Fix order-dependant platform interface tests (flutter#4406)
  [google_maps_flutter]: LatLng longitude loses precision in constructor #90574 (flutter#4374)
  [google_maps_flutter] Add Marker drag events (flutter#2838)
  [flutter_plugin_tools] Validate pubspec description (flutter#4396)
  Add file_selector to the repo list (flutter#4395)
  [in_app_purchase] Fix in_app_purchase_android/README.md (flutter#4363)
  [google_maps_flutter_web] Add Marker drag events (flutter#4385)
  [webview_flutter] Fixed todos in FlutterWebView.java (flutter#4394)
  Handle `PurchaseStatus.restored` correctly in example. (flutter#4393)
  Handle restored purchases in iOS example app (flutter#4392)
  [file_selector] Remove custom analysis options (flutter#4382)
  [flutter_plugin_tools] Check licenses in Kotlin (flutter#4373)
  Fixed _CastError when running example App (flutter#4390)
  [in_app_purchase] Ensure the introductoryPriceMicros field is transported as a String. (flutter#4370)
  ...

# Conflicts:
#	packages/quick_actions/ios/Classes/FLTQuickActionsPlugin.m
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Oct 29, 2021
@engine-flutter-autoroll @clocksmith
4470692 Fixed _CastError when running example App (flutter/plugins#4390…
e831cc8 
…) (flutter#90871)
amantoux pushed a commit to amantoux/plugins that referenced this pull request Dec 11, 2021
@mvanbeusekom @amantoux
Fixed _CastError when running example App (flutter#4390)
d5caa7f
KyleFin pushed a commit to KyleFin/plugins that referenced this pull request Dec 21, 2021
@mvanbeusekom @KyleFin
Fixed _CastError when running example App (flutter#4390)
671dbdd
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BeMacized BeMacized BeMacized approved these changes

Assignees
No one assigned
Labels
cla: yes p: webview_flutter Edits files for a webview_flutter plugin waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[webview_flutter] Example App throws _CastError
3 participants
@mvanbeusekom @BeMacized @fluttergithubbot