Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[in_app_purchase] Fix app exceptions caused by missing App Store receipt #4096

Merged
merged 8 commits into from
Jun 30, 2021
Merged

[in_app_purchase] Fix app exceptions caused by missing App Store receipt #4096

merged 8 commits into from
Jun 30, 2021

Conversation

renefloor
Copy link
Contributor

Description

Missing App Store receipt can happen for different scenarios, thus shouldn't trigger an exception.
Reboot of PR #2862

Related Issues

flutter/flutter#43957

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • [ x ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [ x ] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • [ x ] All existing and new tests are passing.
  • [ x ] I updated/added relevant documentation (doc comments with ///).
  • [ x ] The analyzer (flutter analyze) does not report any problems on my PR.
  • [ x ] I read and followed the Flutter Style Guide.
  • [ x ] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • [ x ] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • [ x ] I updated CHANGELOG.md to add a description of the change.
  • [ x ] I signed the CLA.
  • [ x ] I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • [ x ] No, this is not a breaking change.

@renefloor @LHLL
Fix app exceptions caused by missing App Store receipt
4536d7d 
Rebase of flutter/pull/2862

Co-authored-by: LHLL <yijiexu@google.com>
@renefloor renefloor requested review from cyanglaz and LHLL as code owners June 24, 2021 12:42
@google-cla google-cla bot added the cla: yes label Jun 24, 2021
@renefloor renefloor mentioned this pull request Jun 24, 2021
Closed
1 task
renefloor
renefloor commented Jun 24, 2021
View reviewed changes
Copy link
Contributor Author

@renefloor renefloor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good after xctested

@renefloor renefloor changed the title [in_app_purchase] WIP Fix app exceptions caused by missing App Store receipt [in_app_purchase] Fix app exceptions caused by missing App Store receipt Jun 24, 2021
stuartmorgan-g
stuartmorgan-g suggested changes Jun 25, 2021
View reviewed changes
@vytautas-pranskunas-
Copy link

any updates?

@renefloor
Copy link
Contributor Author

any updates?

@vytautas-pranskunas- I was enjoying my weekend. The requested changes could wait till Monday ;)

@renefloor renefloor requested a review from stuartmorgan-g June 28, 2021 09:50
@renefloor renefloor requested a review from stuartmorgan-g June 29, 2021 09:03
stuartmorgan-g
stuartmorgan-g approved these changes Jun 29, 2021
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@renefloor
Merge branch 'master' into missing-receipt
2a4014a 
# Conflicts:
#	packages/in_app_purchase/in_app_purchase_ios/CHANGELOG.md
#	packages/in_app_purchase/in_app_purchase_ios/pubspec.yaml
@renefloor renefloor added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Jun 30, 2021
@fluttergithubbot fluttergithubbot merged commit acc502e into flutter:master Jun 30, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 30, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 30, 2021
@engine-flutter-autoroll
acc502e [in_app_purchase] Fix app exceptions caused by missing App St…
ec859a0 
…ore receipt (flutter/plugins#4096)
@renefloor renefloor deleted the missing-receipt branch June 30, 2021 13:14
fluttergithubbot pushed a commit to flutter/flutter that referenced this pull request Jun 30, 2021
@engine-flutter-autoroll
acc502e [in_app_purchase] Fix app exceptions caused by missing App St…
76b2f98 
…ore receipt (flutter/plugins#4096) (#85618)
Ralph-Li pushed a commit to Insight-Timer/plugins that referenced this pull request Jul 1, 2021
@adad184
Merge branch 'upstream_v0_8_1+3'
75d8b60 
* upstream_v0_8_1+3: (99 commits)
  [image_picker] Fixed IOException when cache directory is removed (flutter#4117)
  [in_app_purchase] Fix app exceptions caused by missing App Store receipt (flutter#4096)
  Add Basic Junit Tests to some plugins (flutter#4108)
  [image_picker]Update example app (flutter#4103)
  [flutter_plugin_tools] Restructure version-check (flutter#4111)
  Split some Cirrus script steps (flutter#4112)
  [flutter_plugin_tools] Migrate java-test to new base command (flutter#4105)
  [flutter_plugin_tools] ignore flutter_plugin_tools when publishing (flutter#4110)
  [in_app_purchase] Add support for SKPaymentQueueDelegate and showPriceConsentIfNeeded (flutter#4085)
  [flutter_plugin_tools] release 0.3.0 (flutter#4109)
  Migrate command, add failure test, remove skip (flutter#4106)
  Don't install cocoapods; use the version in the image (flutter#4104)
  [flutter_plugin_tools] Migrate analyze to new base command (flutter#4084)
  Add release status badge to README (flutter#4102)
  Build all iOS example apps on current Flutter stable (flutter#4101)
  [url_launcher] Fix test button check for iOS 15 (flutter#4088)
  Update .ci.yaml documentation link (flutter#4090)
  [image_picker] Updated pickImage and pickVideo docs to expose the possible errors that can be thrown (flutter#4089)
  [flutter_plugin_tools] `publish-plugin` check against pub to determine if a release should happen (flutter#4068)
  [webview_flutter] Suppress iOS 9 deprecation warnings (flutter#4100)
  ...

# Conflicts:
#	packages/image_picker/image_picker/ios/Classes/FLTImagePickerPlugin.m
@vladb99 vladb99 mentioned this pull request Jul 6, 2021
Closed
@vladb99
Copy link
Contributor

vladb99 commented Jul 6, 2021

I think this PR introduced a new bug, where app crashes when buyNonConsumable is called. See the above issue for details.

amantoux pushed a commit to amantoux/plugins that referenced this pull request Jul 10, 2021
@renefloor @amantoux
[in_app_purchase] Fix app exceptions caused by missing App Store rece…
face705 
…ipt (flutter#4096)
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@renefloor @fotiDim
[in_app_purchase] Fix app exceptions caused by missing App Store rece…
894c2d0 
…ipt (flutter#4096)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

@LHLL LHLL Awaiting requested review from LHLL

@mvanbeusekom mvanbeusekom Awaiting requested review from mvanbeusekom

Assignees
No one assigned
Labels
cla: yes p: in_app_purchase platform-ios waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@renefloor @vytautas-pranskunas- @vladb99 @stuartmorgan-g @fluttergithubbot