This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[flutter_webview] Fix allowsInlineMediaPlayback ignored on iOS
#3791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
p: webview_flutter
stuartmorgan
approved these changes
Apr 7, 2021
|
|
||
| testWidgets('Video plays inline when allowsInlineMediaPlayback is true', | ||
| (WidgetTester tester) async { | ||
| Completer<WebViewController> controllerCompleter = | ||
| Completer<WebViewController>(); | ||
| Completer<void> pageLoaded = Completer<void>(); | ||
| // String message1; |
There was a problem hiding this comment.
What does this mean (here and below)?
There was a problem hiding this comment.
oops, some testing code not cleaned up :) Good catch! Thanks
| @@ -361,6 +359,18 @@ - (NSString*)applySettings:(NSDictionary<NSString*, id>*)settings { | |||
| [unknownKeys componentsJoinedByString:@", "]]; | |||
| } | |||
|
|
|||
| - (void)applyConfigurationSetting:(NSDictionary<NSString*, id>*)settings | |||
| inConfiguration:(WKWebViewConfiguration*)configuration { | |||
There was a problem hiding this comment.
Also did s/Setting/Settings
cyanglaz
added
the
waiting for tree to go green
added 2 commits
April 6, 2021 19:45
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 7, 2021
fluttergithubbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 7, 2021
bhaveshptl
pushed a commit
to bhaveshptl/plugins
that referenced
this pull request
Apr 23, 2021
* master: (397 commits) [in_app_purchase] Implementation of platform interface (flutter#3781) [google_sign_in] Add todo WRT correctly setting X-Goog-AuthUser header (flutter#3819) [tools] fix version check command not working for new packages (flutter#3818) [camera] android-rework part 1: Base classes to support Android Camera features (flutter#3795) fix MD (flutter#3815) Path provider windows crash fix (flutter#3814) [local_auth] docs update (flutter#3103) Update PULL_REQUEST_TEMPLATE.md (flutter#3801) [quick_actions] handle cold start on iOS correctly (flutter#3811) Replace path_provider_linux widget tests with simple unit tests (flutter#3812) [sensors] format dart code based on the new dart formatter (flutter#3809) [google_sign_in] Fix "pick account" on iOS (flutter#3805) [image_picker_platform_interface] Added pickMultiImage (flutter#3782) [in_app_purchase] Added currency code and numerical price to product detail model. (flutter#3794) [local_auth] Fix iOS crash when no localizedReason (flutter#3780) Fix and update version checks (flutter#3792) [in_app_purchase] Configured example app to use StoreKit Testing on iOS 14 (flutter#3772) [local_auth] Unnecessary reassignment in example removed (flutter#2983) [flutter_webview] Fix `allowsInlineMediaPlayback` ignored on iOS (flutter#3791) Switch script/tools over to the new analysis options (flutter#3777) ...
fotiDim
pushed a commit
to fotiDim/plugins
that referenced
this pull request
Sep 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
allowsInlineMediaPlaybackflag ignored on iOS.This PR also enables some tests that were failing before, as well as the test for
allowsInlineMediaPlaybackFixes: flutter/flutter#73768
Fixes: flutter/flutter#72572
Pre-launch Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.