-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[google_maps_flutter_web] Downgrade mockito in example app. #3679
[google_maps_flutter_web] Downgrade mockito in example app. #3679
Conversation
This will have to be merged in red, to fix the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming other pre submit tasks pass
@cyanglaz this is a good sign: https://cirrus-ci.com/task/4659104154124288?command=main#L68 |
We have a bunch of other plugins using 5.0.0; maybe this should be |
(But LGTM either way) |
@stuartmorgan this is a |
Merging to make tree green again |
* master: [google_sign_in] fix test(flutter#3690) [extension_google_sign_in_as_googleapis_auth] Update import (flutter#3689) [google_sign_in] Updates google_sign_in_platform_interfaces adding parametrized `clientId` (flutter#3686) Import flutter_test for future compatibility (flutter#3665) [ci] Disable analyze on stable for web plugins that contains null safety integration tests. (flutter#3681) Bring HTML inputs into view automatically (flutter#3655) [in_app_purchase] presentCodeRedemptionSheet (flutter#3274) [google_maps_flutter_web] Downgrade mockito in example app. (flutter#3679) Update CI config for Flutter 2 (flutter#3674) [image_picker] fix flutter/flutter#71927 (flutter#3676) [google_maps_flutter_web] Move integration tests to example. (flutter#3675) [google_maps_flutter_web] Make google_maps_flutter_web work with latest plugins (flutter#3673) # Conflicts: # packages/webview_flutter/CHANGELOG.md
Mockito 5 + integration_test from SDK in stable are not compatible:
This is now apparent because the minimum flutter version that we have for "the next stable after 3/3" is ">=1.27.0", however we're now in "2.0.0" (so it passes, when it shouldn't. We now really mean ">=2.1.0", but that'd break CI in stable as well).
This PR downgrades the mockito dependency so it's compatible with the integration_test package that lives in the stable version of the SDK.
Testing
flutter analyze
andflutter build web
both instable
andmaster
channelsPre-launch Checklist
[shared_preferences]
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.