Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Update CI config for Flutter 2 #3674

Merged
merged 21 commits into from
Mar 4, 2021

Conversation

stuartmorgan-g
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g commented Mar 3, 2021

Includes cleanup to simplify our setup. Major changes:

  • Eliminate the NNBD plugin filtering for stable.
  • Remove the temporarily-added beta branch testing.
  • Enable Linux, macOS, and web on stable (Windows is LUCI-based)
  • Combine the two different macOS matrix configurations now that they
    are the same.
  • Combine the two different Linux matrix configurations by using a single
    Dockerfile (which now also includes clang-format)
    • The web integration smoke test temporarily still uses the old Dockerfile,
      now renamed, because the driver installer script doesn't support
      Chrome 89 yet.
  • Move most of the Linux tasks to lower-CPU machines to allow more
    tasks to run in parallel without hitting the community limit.
  • Reorder the tasks slightly and give them comments to identify
    platform groupings
  • Enabled web "build all plugins together" and "build all examples"
    tests

- Remove the temporarily-added beta branch testing.
- Enable Linux and macOS on stable.
- Combine the two different macOS matrix configurations now that they
  are the same.
- Eliminate the NNBD plugin filtering for stable.
@google-cla google-cla bot added the cla: yes label Mar 3, 2021
@stuartmorgan-g
Copy link
Contributor Author

Looks like there are issues with regenerating the Docker instances that would need investigation and reworking, so reverting the merging of the Dockerfiles.

Comment on lines +126 to +128
# These use machines with more CPUs and memory, so will reduce parallelization
# for non-credit runs.
task:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it need cpu and memory values under container?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, there are defaults (2 CPUs and 4 GB)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering what makes these tasks use machines with more CPUs and memory as mentioned in the comment above?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦

I didn't look carefully enough at the context and thought this was about the light-load config. Fix incoming.

Copy link

@blasten blasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g stuartmorgan-g merged commit 47c380a into flutter:master Mar 4, 2021
@stuartmorgan-g stuartmorgan-g deleted the cirrus-updates branch March 4, 2021 21:59
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 4, 2021
fluttergithubbot pushed a commit to flutter/flutter that referenced this pull request Mar 4, 2021
NickalasB added a commit to NickalasB/plugins that referenced this pull request Mar 8, 2021
* master:
  [google_sign_in] fix test(flutter#3690)
  [extension_google_sign_in_as_googleapis_auth] Update import (flutter#3689)
  [google_sign_in] Updates google_sign_in_platform_interfaces adding parametrized `clientId` (flutter#3686)
  Import flutter_test for future compatibility (flutter#3665)
  [ci] Disable analyze on stable for web plugins that contains null safety integration tests.  (flutter#3681)
  Bring HTML inputs into view automatically (flutter#3655)
  [in_app_purchase] presentCodeRedemptionSheet (flutter#3274)
  [google_maps_flutter_web] Downgrade mockito in example app. (flutter#3679)
  Update CI config for Flutter 2 (flutter#3674)
  [image_picker] fix flutter/flutter#71927 (flutter#3676)
  [google_maps_flutter_web] Move integration tests to example. (flutter#3675)
  [google_maps_flutter_web] Make google_maps_flutter_web work with latest plugins  (flutter#3673)

# Conflicts:
#	packages/webview_flutter/CHANGELOG.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants