Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[video_player] fixed misleading size and aspect ratio documentation #3668

Merged
merged 7 commits into from
Mar 10, 2021
Merged

[video_player] fixed misleading size and aspect ratio documentation #3668

merged 7 commits into from
Mar 10, 2021

Conversation

nt4f04uNd
Copy link
Member

fixes flutter/flutter#77112

also, changed formatting for caption contructor

Pre-launch Checklist

  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@google-cla google-cla bot added the cla: yes label Mar 3, 2021
@stuartmorgan-g stuartmorgan-g self-requested a review March 3, 2021 21:21
@stuartmorgan-g
Copy link
Contributor

Thanks for the contribution! Could you add a version bump and CHANGELOG update? We need those in order to publish, and the published version is the version people are likely to be looking at the comments for.

stuartmorgan-g
stuartmorgan-g approved these changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@stuartmorgan-g stuartmorgan-g added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Mar 10, 2021
@fluttergithubbot fluttergithubbot merged commit d306f98 into flutter:master Mar 10, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 10, 2021
@engine-flutter-autoroll
d306f98 [video_player] fixed misleading size and aspect ratio documen…
05c7147 
…tation (flutter/plugins#3668)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 10, 2021
@engine-flutter-autoroll
d306f98 [video_player] fixed misleading size and aspect ratio documen…
8c84210 
…tation (flutter/plugins#3668)
yasargil added a commit to yasargil/plugins that referenced this pull request Mar 18, 2021
@yasargil
Merge branch 'master' into gmain
f6f7fdd 
* master: (49 commits)
  Prep for alignment with Flutter analysis options (flutter#3703)
  [google_maps_flutter_platform_interface] Mark constructors as const for ids (flutter#3718)
  [image_picker] Endorse image_picker_for_web (flutter#3717)
  Add missing licenses, and add a check (flutter#3720)
  [ci] Add libgcrypt to Docker image. (flutter#3711)
  Reorder the checkboxes in the PR template (flutter#3666)
  Re-endorse connectivity_for_web (flutter#3708)
  Fix missing declaration of windows' default_package (flutter#3705)
  Typos in comments (flutter#2846)
  Skip flutter upgrade for pod linting Cirrus task (flutter#3700)
  [cross_file] Delete. (flutter#3698)
  [tool] Improve check version ci so that it enforces the version in CHANGELOG and pubspec matches. (flutter#3678)
  Streamline CI setup, and reenable macOS credits (flutter#3697)
  [video_player] fixed misleading size and aspect ratio documentation (flutter#3668)
  [image_picker] Implemented 2860 and added Unit Test to test functionality (flutter#3685)
  [shared_preferences] Fix concurrent modification of the shared preferences on Android (flutter#3684)
  [extension_google_sign_in_as_googleapis_auth] Deleted. (flutter#3694)
  Skip pod lint tests (flutter#3692)
  [Video_Player] Remove the deprecated API reference. (flutter#3669)
  [google_sign_in] fix test(flutter#3690)
  ...
@nt4f04uNd nt4f04uNd deleted the video_player_fix_docs branch April 9, 2021 21:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

Assignees
No one assigned
Labels
cla: yes p: video_player waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[video_player] misleading VideoPlayerValue documentation
5 participants
@nt4f04uNd @stuartmorgan-g @cyanglaz @fluttergithubbot @stuartmorgan