This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[various] Import flutter_test for future compatibility #3665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The service mocks are going to move from services.dart to flutter_test/.
|
Would you like me to also update the changelogs and so forth, or should I land this silently? (I am fine either way; I hadn't done those changes because I wanted to make sure the tests pass first, but now that I know they pass and it's been approved I can do those and land it without worrying about conflicts as I fix tests etc.) |
|
I don't see a need to publish these changes; I doubt very much that people are running tests from pub-pulled packages rather than cloning. So silent SGTM. |
Hixie
added
the
waiting for tree to go green
|
Roger. I've marked it to land when green. Thanks! |
|
This pull request is not suitable for automatic merging in its current state.
|
fluttergithubbot
removed
the
waiting for tree to go green
godofredoc
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 6, 2021
NickalasB
added a commit
to NickalasB/plugins
that referenced
this pull request
Mar 8, 2021
* master: [google_sign_in] fix test(flutter#3690) [extension_google_sign_in_as_googleapis_auth] Update import (flutter#3689) [google_sign_in] Updates google_sign_in_platform_interfaces adding parametrized `clientId` (flutter#3686) Import flutter_test for future compatibility (flutter#3665) [ci] Disable analyze on stable for web plugins that contains null safety integration tests. (flutter#3681) Bring HTML inputs into view automatically (flutter#3655) [in_app_purchase] presentCodeRedemptionSheet (flutter#3274) [google_maps_flutter_web] Downgrade mockito in example app. (flutter#3679) Update CI config for Flutter 2 (flutter#3674) [image_picker] fix flutter/flutter#71927 (flutter#3676) [google_maps_flutter_web] Move integration tests to example. (flutter#3675) [google_maps_flutter_web] Make google_maps_flutter_web work with latest plugins (flutter#3673) # Conflicts: # packages/webview_flutter/CHANGELOG.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The service mocks are going to move from services.dart to flutter_test/.
See flutter/flutter#76288
Pre-launch Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.